Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: pkg/analysis_server/lib/src/status/get_handler.dart

Issue 2530273004: Status page for the new analysis driver. (Closed)
Patch Set: Fixes for review comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/status/get_handler.dart
diff --git a/pkg/analysis_server/lib/src/status/get_handler.dart b/pkg/analysis_server/lib/src/status/get_handler.dart
index 5a4cdc960eca29b746f48fd45c5f5130dadb3f7d..d6ed6eb611db9cb741c4771156daa6f3eee62515 100644
--- a/pkg/analysis_server/lib/src/status/get_handler.dart
+++ b/pkg/analysis_server/lib/src/status/get_handler.dart
@@ -59,6 +59,16 @@ import 'package:plugin/plugin.dart';
*/
typedef void HtmlGenerator(StringBuffer buffer);
+/**
+ * Instances of the class [AbstractGetHandler] handle GET requests.
+ */
+abstract class AbstractGetHandler {
+ /**
+ * Handle a GET request received by the HTTP server.
+ */
+ void handleGetRequest(HttpRequest request);
+}
+
class ElementCounter extends RecursiveElementVisitor {
Map<Type, int> counts = new HashMap<Type, int>();
int elementsWithDocs = 0;
@@ -197,7 +207,7 @@ class ElementCounter extends RecursiveElementVisitor {
/**
* Instances of the class [GetHandler] handle GET requests.
*/
-class GetHandler {
+class GetHandler implements AbstractGetHandler {
/**
* The path used to request overall performance information.
*/
@@ -2506,6 +2516,9 @@ class GetHandler {
}
buffer.write('<p>');
buffer.write('Status: Running<br>');
+ buffer.write('New analysis driver: ');
+ buffer.write(analysisServer.options.enableNewAnalysisDriver);
+ buffer.write('<br>');
buffer.write('Instrumentation: ');
if (AnalysisEngine.instance.instrumentationService.isActive) {
buffer.write('<span style="color:red">Active</span>');

Powered by Google App Engine
This is Rietveld 408576698