Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2530273003:
[GeometoryInterface] clean up DOMMatrix*.idl files. (Closed)
|
Created:
4 years ago by Hwanseung Lee Modified:
4 years ago CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[GeometoryInterface] clean up DOMMatrix*.idl files.
remove already fixed items.
and change the order as same as specification.
spec list:
https://drafts.fxtf.org/geometry/#DOMMatrix
BUG=388780
Committed: https://crrev.com/82c7ba3bef4274aac8b18c86e14985025abce5ef
Cr-Commit-Position: refs/heads/master@{#438865}
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 21 (14 generated)
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [GeometoryInterface] clean up idl file. remove already fixed item. and change the order as same as specification. spec list: https://drafts.fxtf.org/geometry/#DOMMatrix BUG=388780 ========== to ========== [GeometoryInterface] clean up idl file. remove already fixed items. and change the order as same as specification. spec list: https://drafts.fxtf.org/geometry/#DOMMatrix BUG=388780 ==========
Description was changed from ========== [GeometoryInterface] clean up idl file. remove already fixed items. and change the order as same as specification. spec list: https://drafts.fxtf.org/geometry/#DOMMatrix BUG=388780 ========== to ========== [GeometoryInterface] clean up DOMMatrix*.idl files. remove already fixed items. and change the order as same as specification. spec list: https://drafts.fxtf.org/geometry/#DOMMatrix BUG=388780 ==========
hs1217.lee@samsung.com changed reviewers: + dominicc@chromium.org, jinho.bang@samsung.com
@dominicc, zino PTAL, thank you.
The CQ bit was checked by dominicc@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/Source/core/dom/DOMMatrix.idl:
While running git apply --index -p1;
error: patch failed: third_party/WebKit/Source/core/dom/DOMMatrix.idl:8
error: third_party/WebKit/Source/core/dom/DOMMatrix.idl: patch does not apply
Patch: third_party/WebKit/Source/core/dom/DOMMatrix.idl
Index: third_party/WebKit/Source/core/dom/DOMMatrix.idl
diff --git a/third_party/WebKit/Source/core/dom/DOMMatrix.idl
b/third_party/WebKit/Source/core/dom/DOMMatrix.idl
index
1017e5a242d8461c35172b9c304a829ae9e3fcc2..6995332b98f656128315e965ffc7eded88338ba8
100644
--- a/third_party/WebKit/Source/core/dom/DOMMatrix.idl
+++ b/third_party/WebKit/Source/core/dom/DOMMatrix.idl
@@ -8,13 +8,12 @@
Constructor,
Constructor(sequence<unrestricted double> numberSequence),
RaisesException=Constructor,
- // FIXME: Should implement more constructors (See: crbug.com/388780)
// FIXME: Exposed=(Window,Worker)
RuntimeEnabled=GeometryInterfaces,
] interface DOMMatrix : DOMMatrixReadOnly {
+ [RaisesException, NewObject] static DOMMatrix fromMatrix(optional
DOMMatrixInit other);
[RaisesException, NewObject] static DOMMatrix fromFloat32Array(Float32Array
array32);
[RaisesException, NewObject] static DOMMatrix fromFloat64Array(Float64Array
array64);
- [RaisesException, NewObject] static DOMMatrix fromMatrix(optional
DOMMatrixInit other);
// These attributes are simple aliases for certain elements of the 4x4
matrix
inherit attribute unrestricted double a;
The CQ bit was checked by hs1217.lee@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from dominicc@chromium.org Link to the patchset: https://codereview.chromium.org/2530273003/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481817215981600,
"parent_rev": "f2a79974f17d8f1b4552de9d8f5a67e36da309bd", "commit_rev":
"88c86dd50e4fcbf8dc609ca2fde235fc243d7481"}
Message was sent while issue was closed.
Description was changed from ========== [GeometoryInterface] clean up DOMMatrix*.idl files. remove already fixed items. and change the order as same as specification. spec list: https://drafts.fxtf.org/geometry/#DOMMatrix BUG=388780 ========== to ========== [GeometoryInterface] clean up DOMMatrix*.idl files. remove already fixed items. and change the order as same as specification. spec list: https://drafts.fxtf.org/geometry/#DOMMatrix BUG=388780 Review-Url: https://codereview.chromium.org/2530273003 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [GeometoryInterface] clean up DOMMatrix*.idl files. remove already fixed items. and change the order as same as specification. spec list: https://drafts.fxtf.org/geometry/#DOMMatrix BUG=388780 Review-Url: https://codereview.chromium.org/2530273003 ========== to ========== [GeometoryInterface] clean up DOMMatrix*.idl files. remove already fixed items. and change the order as same as specification. spec list: https://drafts.fxtf.org/geometry/#DOMMatrix BUG=388780 Committed: https://crrev.com/82c7ba3bef4274aac8b18c86e14985025abce5ef Cr-Commit-Position: refs/heads/master@{#438865} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/82c7ba3bef4274aac8b18c86e14985025abce5ef Cr-Commit-Position: refs/heads/master@{#438865} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
