Add MapMixin to dart:collection.

Add MapMixin to dart:collection.

BUG= http://dartbug.com/10128
R=ajohnsen@google.com, floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35904

[Lasse Reichstein Nielsen, 2014-04-29 11:31:10]

Alternative: Make MapBase be usable as a mixin (just entails removing the
constructor that was added to prevent it being used as a mixin).

[kevmoo, 2014-04-29 13:41:11]

DBC

Take a look at the new lines in the doc comments. To have a newline rendered in
the html you need two line breaks.

So either add one or remove one, per your preference. :-)

https://api.dartlang.org/apidocs/channels/be/dartdoc-viewer/dart-collection.M...

https://codereview.chromium.org/253023004/diff/1/sdk/lib/collection/maps.dart
File sdk/lib/collection/maps.dart (right):

https://codereview.chromium.org/253023004/diff/1/sdk/lib/collection/maps.dart...
sdk/lib/collection/maps.dart:12: * A basic `Map` class can be implemented by
extending this class and
While you're at it, add a blank line here, too.

https://codereview.chromium.org/253023004/diff/1/sdk/lib/collection/maps.dart...
sdk/lib/collection/maps.dart:31: * A basic `Map` class can be implemented by
mixin in this class and
include a blank line after the first sentence.

[Lasse Reichstein Nielsen, 2014-04-29 13:52:27]

I believe the line breaks are exactly where I want them :).

I try to write doc comments so they are both readable and easily modifiable -
because I tend to have to modify them when they aren't readable enough anyway
:).

To that end, I try to split lines between separate sentence parts, or between
sentences, even if they are part of the same paragraph. That avoids having to
reflow the text when changing a single sentence or sentence part. It's annoying
to have to move two words through multiple lines until you reach a short line.

That does mean that some sentences end early on a line, but I don't find that to
cause any problems in practice. In HTML documentation, it all flows together
anyway, ditto inside the editor's popup documentation, and when reading directly
in the code, it's still readable.

https://codereview.chromium.org/253023004/diff/1/sdk/lib/collection/maps.dart
File sdk/lib/collection/maps.dart (right):

https://codereview.chromium.org/253023004/diff/1/sdk/lib/collection/maps.dart...
sdk/lib/collection/maps.dart:12: * A basic `Map` class can be implemented by
extending this class and
I wanted this to be part of the same paragraph as the previous line. The "all
but five members" cannot really stand by itself, it needs those members to be
mentioned, and preferably in the same paragraph.

[Lasse Reichstein Nielsen, 2014-05-07 10:57:26]

Ping Anders.

[Anders Johnsen, 2014-05-07 10:58:32]

lgtm

[floitsch, 2014-05-07 11:06:48]

LGTM.
sorry. forgot again.

[Johnni Winther, 2014-05-07 11:21:28]

I think we need https://codereview.chromium.org/267153002/ to be committed
before this CL.

[Lasse Reichstein Nielsen, 2014-05-08 11:36:20]

Committed patchset #1 manually as r35904 (presubmit successful).