Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2415)

Unified Diff: tests/corelib/map_test.dart

Issue 253023004: Add MapMixin to dart:collection. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/collection/maps.dart ('K') | « sdk/lib/collection/maps.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/corelib/map_test.dart
diff --git a/tests/corelib/map_test.dart b/tests/corelib/map_test.dart
index a432b48127159cefd05c970c159cbb2d2d8fbc23..564cf884c6be04f6c11a8b80a4a7564172d602a0 100644
--- a/tests/corelib/map_test.dart
+++ b/tests/corelib/map_test.dart
@@ -14,6 +14,7 @@ void main() {
test(new MapView(new HashMap()));
test(new MapView(new SplayTreeMap()));
test(new MapBaseMap());
+ test(new MapMixinMap());
testLinkedHashMap();
testMapLiteral();
testNullValue();
@@ -28,6 +29,7 @@ void main() {
testWeirdStringKeys(new SplayTreeMap());
testWeirdStringKeys(new SplayTreeMap<String, String>());
testWeirdStringKeys(new MapBaseMap<String, String>());
+ testWeirdStringKeys(new MapMixinMap<String, String>());
testNumericKeys(new Map());
testNumericKeys(new Map<num, String>());
@@ -40,6 +42,7 @@ void main() {
testNumericKeys(new LinkedHashMap.identity());
testNumericKeys(new LinkedHashMap<num, String>.identity());
testNumericKeys(new MapBaseMap<num, String>());
+ testNumericKeys(new MapMixinMap<num, String>());
testNaNKeys(new Map());
testNaNKeys(new Map<num, String>());
@@ -48,6 +51,7 @@ void main() {
testNaNKeys(new LinkedHashMap());
testNaNKeys(new LinkedHashMap<num, String>());
testNaNKeys(new MapBaseMap<num, String>());
+ testNaNKeys(new MapMixinMap<num, String>());
// Identity maps fail the NaN-keys tests because the test assumes that
// NaN is not equal to NaN.
@@ -96,6 +100,7 @@ void main() {
hashCode: (int v) => v.hashCode,
isValidKey: (v) => v is int));
testOtherKeys(new MapBaseMap<int, int>());
+ testOtherKeys(new MapMixinMap<int, int>());
testUnmodifiableMap(const {1 : 37});
testUnmodifiableMap(new UnmodifiableMapView({1 : 37}));
@@ -775,7 +780,7 @@ class Mutable {
// Slow implementation of Map based on MapBase.
-class MapBaseMap<K, V> extends MapBase<K, V> {
+abstract class MapBaseOperations<K, V> {
final List _keys = <K>[];
final List _values = <V>[];
int _modCount = 0;
@@ -824,6 +829,9 @@ class MapBaseMap<K, V> extends MapBase<K, V> {
}
}
+class MapBaseMap<K, V> = MapBase<K, V> with MapBaseOperations<K, V>;
+class MapMixinMap<K, V> = MapBaseOperations<K, V> with MapMixin<K, V>;
+
class TestKeyIterable<K> extends IterableBase<K> {
final _map;
TestKeyIterable(this._map);
« sdk/lib/collection/maps.dart ('K') | « sdk/lib/collection/maps.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698