Chromium Code Reviews| Index: chrome/install_static/install_details.h |
| diff --git a/chrome/install_static/install_details.h b/chrome/install_static/install_details.h |
| index 7b6d90d85cd8aa62123f1cf27970a8bd8d1a7c8c..c0aba6d2f3495c2a875abeec76848035790d73d4 100644 |
| --- a/chrome/install_static/install_details.h |
| +++ b/chrome/install_static/install_details.h |
| @@ -14,6 +14,10 @@ namespace install_static { |
| class PrimaryInstallDetails; |
| +// Re-declare the constants from install_modes.h to avoid cyclical dependency. |
|
grt (UTC plus 2)
2016/11/28 12:49:52
should install_modes.h really be including install
pastarmovj
2016/11/28 15:53:17
Fixed includes globally.
|
| +extern const wchar_t kProductPathName[]; |
| +extern const size_t kProductPathNameLength; |
| + |
| // Details relating to how Chrome is installed. This class and |
| // PrimaryInstallDetails (below) are used in tandem so that one instance of the |
| // latter may be initialized early during process startup and then shared with |
| @@ -72,6 +76,13 @@ class InstallDetails { |
| return payload_->mode->install_suffix; |
| } |
| + // Returns the full name of the installed product (e.g. "Chrome SxS" for |
| + // canary chrome). |
| + std::wstring install_full_name() const { |
|
grt (UTC plus 2)
2016/11/28 12:49:52
i'd be inclined to make this GetInstallFullName an
pastarmovj
2016/11/28 15:53:17
Acknowledged.
|
| + return std::wstring(kProductPathName, kProductPathNameLength) |
| + .append(install_suffix()); |
| + } |
| + |
| // The app GUID with which this mode is registered with Google Update, or an |
| // empty string if this brand does not integrate with Google Update. |
| const wchar_t* app_guid() const { return payload_->mode->app_guid; } |