Make the name of the event source for SYSLOG configurable.

chrome/install_static/install_details.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_INSTALL_STATIC_INSTALL_DETAILS_H_
 #define CHROME_INSTALL_STATIC_INSTALL_DETAILS_H_
 
 #include <memory>
 #include <string>
 
 #include "chrome/install_static/install_constants.h"
 
 namespace install_static {
 
 class PrimaryInstallDetails;
 
+// Re-declare the constants from install_modes.h to avoid cyclical dependency.

[grt (UTC plus 2), 2016/11/28 12:49:52]

should install_modes.h really be including install_constants.h rather than
install_details.h? if so, does fixing that remove the need for this?

[pastarmovj, 2016/11/28 15:53:17]

Fixed includes globally.

+extern const wchar_t kProductPathName[];
+extern const size_t kProductPathNameLength;
+
 // Details relating to how Chrome is installed. This class and
 // PrimaryInstallDetails (below) are used in tandem so that one instance of the
 // latter may be initialized early during process startup and then shared with
 // other modules in the process. For example, chrome_elf creates the instance
 // for a Chrome process and exports a GetInstallDetailsPayload function used by
 // chrome.exe and chrome.dll to create their own module-specific instances
 // referring to the same underlying payload. See install_modes.h for a gentle
 // introduction to such terms as "brand" and "mode".
 class InstallDetails {
  public:
@@ skipping 38 matching lines @@
   // This mode's index into the brand's array of install modes. This will match
   // a brand-specific InstallConstantIndex enumerator.
   int install_mode_index() const { return payload_->mode->index; }
 
   // The mode's install suffix (e.g., " SxS" for canary Chrome), or an empty
   // string for a brand's primary install mode.
   const wchar_t* install_suffix() const {
     return payload_->mode->install_suffix;
   }
 
+  // Returns the full name of the installed product (e.g. "Chrome SxS" for
+  // canary chrome).
+  std::wstring install_full_name() const {

[grt (UTC plus 2), 2016/11/28 12:49:52]

i'd be inclined to make this GetInstallFullName and de-inline it to get rid of
the ugly declarations above if changing install_modes.h doesn't allow for it

[pastarmovj, 2016/11/28 15:53:17]

Acknowledged.

+    return std::wstring(kProductPathName, kProductPathNameLength)
+        .append(install_suffix());
+  }
+
   // The app GUID with which this mode is registered with Google Update, or an
   // empty string if this brand does not integrate with Google Update.
   const wchar_t* app_guid() const { return payload_->mode->app_guid; }
 
   // True if the mode supports installation at system-level.
   bool supports_system_level() const {
     return payload_->mode->supports_system_level;
   }
 
   // True if the mode supports multi-install.
@@ skipping 78 matching lines @@
   }
 
  private:
   std::wstring channel_;
   Payload payload_ = Payload();
 };
 
 }  // namespace install_static
 
 #endif  // CHROME_INSTALL_STATIC_INSTALL_DETAILS_H_