Add MSA optimized ARGB Multiply/Add/Subtract row functions

Add MSA optimized ARGB Multiply/Add/Subtract row functions

R=fbarchard@google.com
BUG=libyuv:634
Performance Gain (vs C vectorized)
ARGBMultiplyRow_MSA       - 1.4x
ARGBAddRow_MSA            - 8.6x
ARGBSubtractRow_MSA       - 8.6x

ARGBMultiplyRow_Any_MSA   - 1.35x
ARGBAddRow_Any_MSA        - 7.3x
ARGBSubtractRow_Any_MSA   - 7.2x


Performance Gain (vs C non-vectorized)
ARGBMultiplyRow_MSA       - 4.4x
ARGBAddRow_MSA            - 27x
ARGBSubtractRow_MSA       - 22x

ARGBMultiplyRow_Any_MSA   - 3.5x
ARGBAddRow_Any_MSA        - 23x
ARGBSubtractRow_Any_MSA   - 18x

Committed: https://chromium.googlesource.com/libyuv/libyuv/+/83f460be3324ccd546ca45e6c282e8f201853e54

[manojkumar.bhosale, 2016-11-24 16:13:48]

Description was changed from

==========
Add MSA optimized ARGB Multiply/Add/Subtract row functions

R=fbarchard@google.com
BUG=libyuv:634
==========

to

==========
Add MSA optimized ARGB Multiply/Add/Subtract row functions

R=fbarchard@google.com
BUG=libyuv:634

Performance Gain (vs C vectorized)
ARGBMultiplyRow_MSA       - 1.4x
ARGBAddRow_MSA            - 8.6x
ARGBSubtractRow_MSA       - 8.6x

ARGBMultiplyRow_Any_MSA   - 1.35x
ARGBAddRow_Any_MSA        - 7.3x
ARGBSubtractRow_Any_MSA   - 7.2x


Performance Gain (vs C non-vectorized)
ARGBMultiplyRow_MSA       - 4.4x
ARGBAddRow_MSA            - 27x
ARGBSubtractRow_MSA       - 22x

ARGBMultiplyRow_Any_MSA   - 3.5x
ARGBAddRow_Any_MSA        - 23x
ARGBSubtractRow_Any_MSA   - 18x
==========

[manojkumar.bhosale, 2016-11-24 16:13:48]

manojkumar.bhosale@imgtec.com changed reviewers:
+ kjellander@chromium.org

[manojkumar.bhosale, 2016-11-24 16:14:09]

Updated with reviewers, cc list and performance gain numbers

[fbarchard1, 2016-11-30 05:04:43]

lgtm

[kjellander_chromium, 2016-11-30 08:24:18]

kjellander@chromium.org changed reviewers:
- kjellander@chromium.org

[manojkumar.bhosale, 2016-11-30 09:19:53]

On 2016/11/30 05:04:43, fbarchard1 wrote:
> lgtm

Hi,

I tried landing the patch, however, it failed as below :-

Review URL: https://codereview.chromium.org/2529983002 .
 include/libyuv/row.h       |   27 +++++++++++++++
 source/planar_functions.cc |   24 +++++++++++++
 source/row_any.cc          |    9 +++++
 source/row_msa.cc          |   81 ++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 141 insertions(+)
remote: Processing changes: refs: 1, done
error: failed to push some refs to
'https://chromium.googlesource.com/libyuv/libyuv'
Failed to push. If this persists, please file a bug.

Is it a permission issue?

[manojkumar.bhosale, 2016-12-02 09:50:25]

Description was changed from

==========
Add MSA optimized ARGB Multiply/Add/Subtract row functions

R=fbarchard@google.com
BUG=libyuv:634

Performance Gain (vs C vectorized)
ARGBMultiplyRow_MSA       - 1.4x
ARGBAddRow_MSA            - 8.6x
ARGBSubtractRow_MSA       - 8.6x

ARGBMultiplyRow_Any_MSA   - 1.35x
ARGBAddRow_Any_MSA        - 7.3x
ARGBSubtractRow_Any_MSA   - 7.2x


Performance Gain (vs C non-vectorized)
ARGBMultiplyRow_MSA       - 4.4x
ARGBAddRow_MSA            - 27x
ARGBSubtractRow_MSA       - 22x

ARGBMultiplyRow_Any_MSA   - 3.5x
ARGBAddRow_Any_MSA        - 23x
ARGBSubtractRow_Any_MSA   - 18x
==========

to

==========
Add MSA optimized ARGB Multiply/Add/Subtract row functions

R=fbarchard@google.com
BUG=libyuv:634

Performance Gain (vs C vectorized)
ARGBMultiplyRow_MSA       - 1.4x
ARGBAddRow_MSA            - 8.6x
ARGBSubtractRow_MSA       - 8.6x

ARGBMultiplyRow_Any_MSA   - 1.35x
ARGBAddRow_Any_MSA        - 7.3x
ARGBSubtractRow_Any_MSA   - 7.2x


Performance Gain (vs C non-vectorized)
ARGBMultiplyRow_MSA       - 4.4x
ARGBAddRow_MSA            - 27x
ARGBSubtractRow_MSA       - 22x

ARGBMultiplyRow_Any_MSA   - 3.5x
ARGBAddRow_Any_MSA        - 23x
ARGBSubtractRow_Any_MSA   - 18x

Committed:
https://chromium.googlesource.com/libyuv/libyuv/+/83f460be3324ccd546ca45e6c28...
==========

[manojkumar.bhosale, 2016-12-02 09:50:31]

Committed patchset #2 (id:20001) manually as
83f460be3324ccd546ca45e6c282e8f201853e54 (presubmit successful).