Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: content/browser/renderer_host/media/audio_output_authorization_handler.h

Issue 2529853002: Fix shutdown crash in AudioOutputAuthorizationHandler. (Closed)
Patch Set: Add mac comment. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_output_authorization_handler.h
diff --git a/content/browser/renderer_host/media/audio_output_authorization_handler.h b/content/browser/renderer_host/media/audio_output_authorization_handler.h
index 1a18a3af7bd7862fa2881ad08595a99311e186d4..4fa47d4c3d5bf338dce85e8d8a2ad71aa5717844 100644
--- a/content/browser/renderer_host/media/audio_output_authorization_handler.h
+++ b/content/browser/renderer_host/media/audio_output_authorization_handler.h
@@ -40,7 +40,10 @@ class CONTENT_EXPORT AudioOutputAuthorizationHandler {
const media::AudioParameters& params,
const std::string& raw_device_id)>;
- AudioOutputAuthorizationHandler(MediaStreamManager* media_stream_manager,
+ // |audio_manager| and |media_stream_manager| must outlive the
+ // AudioOutputAuthorizationHandler.
o1ka 2016/11/24 13:17:36 This is kind of obvious: you pass pointers to them
Max Morin 2016/11/24 14:12:20 Done.
+ AudioOutputAuthorizationHandler(media::AudioManager* audio_manager,
+ MediaStreamManager* media_stream_manager,
int render_process_id_,
const std::string& salt);
@@ -83,6 +86,7 @@ class CONTENT_EXPORT AudioOutputAuthorizationHandler {
const std::string& raw_device_id,
const media::AudioParameters& output_params) const;
+ media::AudioManager* audio_manager_;
MediaStreamManager* const media_stream_manager_;
std::unique_ptr<MediaDevicesPermissionChecker> permission_checker_;
const int render_process_id_;

Powered by Google App Engine
This is Rietveld 408576698