Fix shutdown crash in AudioOutputAuthorizationHandler.

content/browser/renderer_host/media/audio_output_authorization_handler.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_MEDIA_AUDIO_OUTPUT_AUTHORIZATION_HANDLER_H_
 #define CONTENT_BROWSER_RENDERER_HOST_MEDIA_AUDIO_OUTPUT_AUTHORIZATION_HANDLER_H_
 
 #include <memory>
 #include <string>
 #include <utility>
@@ skipping 22 matching lines @@
   // also has the default audio parameters for the device, and the id for the
   // device, which is needed to open a stream for the device. This id is not
   // hashed, so it must be hashed before sending it to the renderer.
   // TODO(maxmorin): Change to OnceCallback once base:: code is ready for it.
   using AuthorizationCompletedCallback =
       base::Callback<void(media::OutputDeviceStatus status,
                           bool should_send_id,
                           const media::AudioParameters& params,
                           const std::string& raw_device_id)>;
 
-  AudioOutputAuthorizationHandler(MediaStreamManager* media_stream_manager,
+  // |audio_manager| and |media_stream_manager| must outlive the
+  // AudioOutputAuthorizationHandler.

[o1ka, 2016/11/24 13:17:36]

This is kind of obvious: you pass pointers to them in the constructor.

[Max Morin, 2016/11/24 14:12:20]

Done.

+  AudioOutputAuthorizationHandler(media::AudioManager* audio_manager,
+                                  MediaStreamManager* media_stream_manager,
                                   int render_process_id_,
                                   const std::string& salt);
 
   ~AudioOutputAuthorizationHandler();
 
   // Checks authorization of the device with the hashed id |device_id| for the
   // given render frame id and security origin, or uses |session_id| for
   // authorization. Looks up device id (if |session_id| is used for device
   // selection) and default device parameters.
   void RequestDeviceAuthorization(int render_frame_id,
@@ skipping 22 matching lines @@
 
   void GetDeviceParameters(AuthorizationCompletedCallback cb,
                            const std::string& raw_device_id) const;
 
   void DeviceParametersReceived(
       AuthorizationCompletedCallback cb,
       bool should_send_id,
       const std::string& raw_device_id,
       const media::AudioParameters& output_params) const;
 
+  media::AudioManager* audio_manager_;
   MediaStreamManager* const media_stream_manager_;
   std::unique_ptr<MediaDevicesPermissionChecker> permission_checker_;
   const int render_process_id_;
   const std::string salt_;
   // All access is on the IO thread, and taking a weak pointer to const looks
   // const, so this can be mutable.
   mutable base::WeakPtrFactory<const AudioOutputAuthorizationHandler>
       weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AudioOutputAuthorizationHandler);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_MEDIA_AUDIO_OUTPUT_AUTHORIZATION_HANDLER_H_