Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2529713002: Run the WebGL conformance tests with the passthrough command decoder. (Closed)

Created:
4 years ago by Geoff Lang
Modified:
4 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, piman, Jamie Madill, Corentin Wallez
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run the WebGL conformance tests with the passthrough command decoder. BUG=668223 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/774e87a5a2ecea722c2d03b14c6a1f20f404ab7e Cr-Commit-Position: refs/heads/master@{#436316}

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 #

Patch Set 4 : expectations #

Patch Set 5 : expectations #

Patch Set 6 : optional/fyi only #

Patch Set 7 : Remove buildbot changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -5 lines) Patch
M content/browser/gpu/gpu_internals_ui.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M content/test/gpu/gpu_tests/gpu_test_expectations.py View 1 2 3 4 5 chunks +15 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 2 3 4 5 6 2 chunks +110 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gpu/config/gpu_info.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/config/gpu_info.cc View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M gpu/config/gpu_info_collector.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/ipc/common/gpu_info.mojom View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/common/gpu_info_struct_traits.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/ipc/common/gpu_info_struct_traits.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/common/gpu_param_traits_macros.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/common/struct_traits_unittest.cc View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_init.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 40 (29 generated)
Geoff Lang
PTAL
4 years ago (2016-11-29 20:09:30 UTC) #23
dcheng
Does using the passthrough command decoder have any security implications? Is this a mode we ...
4 years ago (2016-11-29 22:42:49 UTC) #24
Geoff Lang
On 2016/11/29 22:42:49, dcheng wrote: > Does using the passthrough command decoder have any security ...
4 years ago (2016-11-30 18:14:02 UTC) #25
dcheng
rs lgtm in that case
4 years ago (2016-12-01 01:07:52 UTC) #26
Ken Russell (switch to Gerrit)
Very nice. LGTM
4 years ago (2016-12-01 06:59:37 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529713002/100001
4 years ago (2016-12-01 15:19:57 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/5628)
4 years ago (2016-12-01 18:21:38 UTC) #31
Geoff Lang
Another issue is now blocking running this on the bot. I removed the buildbot changes ...
4 years ago (2016-12-05 15:16:53 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529713002/120001
4 years ago (2016-12-05 15:17:20 UTC) #35
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years ago (2016-12-05 16:29:32 UTC) #38
commit-bot: I haz the power
4 years ago (2016-12-05 16:31:24 UTC) #40
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/774e87a5a2ecea722c2d03b14c6a1f20f404ab7e
Cr-Commit-Position: refs/heads/master@{#436316}

Powered by Google App Engine
This is Rietveld 408576698