Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1547)

Unified Diff: components/offline_pages/offline_event_logger.h

Issue 2529603004: [Offline Pages] Expanding event logger to be used by harness. (Closed)
Patch Set: more comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/BUILD.gn ('k') | components/offline_pages/offline_event_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/offline_event_logger.h
diff --git a/components/offline_pages/offline_event_logger.h b/components/offline_pages/offline_event_logger.h
index 95ac36cc7914303dcb8f22f99e65b7db19141389..0466c8fd28e8ad232abc2207452025919791f7e8 100644
--- a/components/offline_pages/offline_event_logger.h
+++ b/components/offline_pages/offline_event_logger.h
@@ -13,8 +13,9 @@
namespace offline_pages {
-// Maximum number of recorded Logs to keep track of at any moment.
-static const size_t kMaxLogCount = 50;
+// Maximum number of recorded Logs to keep track of at any moment. Defined in
+// offline_event_logger.cc.
+extern const size_t kMaxLogCount;
// Facilitates the logging of events. Subclasses should create methods that
// call RecordActivity to write into the log. |SetIsLogging|, |GetLogs|, and
@@ -27,6 +28,16 @@ static const size_t kMaxLogCount = 50;
// This log only keeps track of the last |kMaxLogCount| events.
class OfflineEventLogger {
public:
+ // This client interface should be implemented by the class which provides the
+ // ability to pipe the log somewhere else (Eg. a java class which can write
+ // logs into a file). It's optional and uses SetClient() to attach the client
+ // to the event logger instance.
+ class Client {
+ public:
+ virtual ~Client(){};
+ virtual void CustomLog(const std::string& message) = 0;
+ };
+
OfflineEventLogger();
~OfflineEventLogger();
@@ -43,16 +54,21 @@ class OfflineEventLogger {
// Dumps the current activity list into |records|.
void GetLogs(std::vector<std::string>* records);
- protected:
// Write the activity into the cycling log if we are currently logging.
void RecordActivity(const std::string& activity);
+ // Sets the client for custom logging process if needed.
+ void SetClient(Client* client);
+
private:
// Recorded offline page activities.
std::deque<std::string> activities_;
// Whether we are currently recording logs or not.
bool is_logging_;
+
+ // Not owned.
+ Client* client_;
};
} // namespace offline_pages
« no previous file with comments | « components/offline_pages/BUILD.gn ('k') | components/offline_pages/offline_event_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698