Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: components/offline_pages/offline_event_logger.cc

Issue 2529603004: [Offline Pages] Expanding event logger to be used by harness. (Closed)
Patch Set: more comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_event_logger.cc
diff --git a/components/offline_pages/offline_event_logger.cc b/components/offline_pages/offline_event_logger.cc
index 810c2a667e670621ca37eb0b15eff815388b3744..28229368379ee11c68268a5c2e87547e9eeb73d2 100644
--- a/components/offline_pages/offline_event_logger.cc
+++ b/components/offline_pages/offline_event_logger.cc
@@ -8,11 +8,17 @@
namespace offline_pages {
+extern const size_t kMaxLogCount = 50;
+
OfflineEventLogger::OfflineEventLogger()
- : activities_(kMaxLogCount), is_logging_(false) {}
+ : activities_(0), is_logging_(false), client_(nullptr) {}
OfflineEventLogger::~OfflineEventLogger() {}
+void OfflineEventLogger::Clear() {
+ activities_.clear();
+}
+
void OfflineEventLogger::SetIsLogging(bool is_logging) {
is_logging_ = is_logging;
}
@@ -21,16 +27,14 @@ bool OfflineEventLogger::GetIsLogging() {
return is_logging_;
}
-void OfflineEventLogger::Clear() {
- activities_.clear();
+void OfflineEventLogger::GetLogs(std::vector<std::string>* records) {
+ DCHECK(records);
+ records->insert(records->end(), activities_.begin(), activities_.end());
}
void OfflineEventLogger::RecordActivity(const std::string& activity) {
- if (!is_logging_) {
+ if (!is_logging_ || activity.empty())
return;
- }
- if (activities_.size() == kMaxLogCount)
- activities_.pop_back();
base::Time::Exploded current_time;
base::Time::Now().LocalExplode(&current_time);
@@ -44,16 +48,20 @@ void OfflineEventLogger::RecordActivity(const std::string& activity) {
current_time.minute,
current_time.second);
- activities_.push_front(date_string + ": " + activity);
+ std::string log_message = date_string + ": " + activity;
+ if (client_)
+ client_->CustomLog(log_message);
+
+ if (activities_.size() == kMaxLogCount)
+ activities_.pop_back();
+
+ activities_.push_front(log_message);
}
-void OfflineEventLogger::GetLogs(std::vector<std::string>* records) {
- DCHECK(records);
- for (std::deque<std::string>::iterator it = activities_.begin();
- it != activities_.end(); it++) {
- if (!it->empty())
- records->push_back(*it);
- }
+void OfflineEventLogger::SetClient(Client* client) {
+ DCHECK(client);
+ SetIsLogging(true);
+ client_ = client;
}
} // namespace offline_pages
« no previous file with comments | « components/offline_pages/offline_event_logger.h ('k') | components/offline_pages/offline_event_logger_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698