Issue 2529433002: [Offline pages] Addressing several reload snackbar issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2529433002: [Offline pages] Addressing several reload snackbar issues (Closed)

Created:
4 years, 1 month ago by fgorski

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

[Offline pages] Addressing several reload snackbar issues * Solves the problem of snackbar not working after incognito tabs being dismissed * solves the problem of snackbar not working when there is a download happening in between. BUG=663263, 662353, 660577 Review-Url: https://codereview.chromium.org/2520583002 Cr-Commit-Position: refs/heads/master@{#433700} (cherry picked from commit b7c13b94eafad8d7458bde05ca6733eb11d731be) Committed: https://chromium.googlesource.com/chromium/src/+/d7cde35af699b567f1cd88ffbebd3b12623f133f

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -5 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java	View		4 chunks	+28 lines, -4 lines	0 comments	Download
	M	chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

fgorski

4 years, 1 month ago (2016-11-22 18:14:58 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d7cde35af699b567f1cd88ffbebd3b12623f133f.