[Offline pages] Addressing several reload snackbar issues

[Offline pages] Addressing several reload snackbar issues

* Solves the problem of snackbar not working after incognito tabs being
  dismissed
* solves the problem of snackbar not working when there is a download
  happening in between.

BUG=663263, 662353, 660577
Committed: https://crrev.com/b7c13b94eafad8d7458bde05ca6733eb11d731be
Cr-Commit-Position: refs/heads/master@{#433700}

[fgorski, 2016-11-19 00:02:33]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-19 00:03:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 00:42:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 00:42:46]

Dry run: This issue passed the CQ dry run.

[fgorski, 2016-11-21 21:24:28]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 21:25:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-11-21 21:26:41]

fgorski@chromium.org changed reviewers:
+ jianli@chromium.org

[fgorski, 2016-11-21 21:26:42]

ptal

[commit-bot: I haz the power, 2016-11-21 22:05:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 22:05:50]

Dry run: This issue passed the CQ dry run.

[jianli, 2016-11-21 22:35:54]

mostly looked good.

I have concern that our OfflinePageTabObserver logic becomes more and more
complicated in order to handle different edge cases due to our dynamic nature. I
am wondering if we can just always observe the tab to simplify the logic.

Can you also find an Android tab expert to take a look?

[jianli, 2016-11-21 23:13:04]

lgtm

[fgorski, 2016-11-21 23:41:51]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2016-11-21 23:42:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 23:51:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479771711470700,
"parent_rev": "87310e99950dd6c3a1e5699caf0069ca03f246f8", "commit_rev":
"ae5c477a9d222492ce69c6bd3baac39fd6d63e39"}

[commit-bot: I haz the power, 2016-11-21 23:52:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-21 23:56:39]

Description was changed from

==========
[Offline pages] Addressing several reload snackbar issues

* Solves the problem of snackbar not working after incognito tabs being
  dismissed
* solves the problem of snackbar not working when there is a download
  happening in between.

BUG=663263,662353,660577
==========

to

==========
[Offline pages] Addressing several reload snackbar issues

* Solves the problem of snackbar not working after incognito tabs being
  dismissed
* solves the problem of snackbar not working when there is a download
  happening in between.

BUG=663263,662353,660577

Committed: https://crrev.com/b7c13b94eafad8d7458bde05ca6733eb11d731be
Cr-Commit-Position: refs/heads/master@{#433700}
==========

[commit-bot: I haz the power, 2016-11-21 23:56:40]

Patchset 2 (id:??) landed as
https://crrev.com/b7c13b94eafad8d7458bde05ca6733eb11d731be
Cr-Commit-Position: refs/heads/master@{#433700}