Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2520583002: [Offline pages] Addressing several reload snackbar issues (Closed)

Created:
4 years, 1 month ago by fgorski
Modified:
4 years, 1 month ago
Reviewers:
jianli
CC:
chromium-reviews, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, agrieve+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Addressing several reload snackbar issues * Solves the problem of snackbar not working after incognito tabs being dismissed * solves the problem of snackbar not working when there is a download happening in between. BUG=663263, 662353, 660577 Committed: https://crrev.com/b7c13b94eafad8d7458bde05ca6733eb11d731be Cr-Commit-Position: refs/heads/master@{#433700}

Patch Set 1 #

Patch Set 2 : Fixing logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java View 4 chunks +28 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
fgorski
ptal
4 years, 1 month ago (2016-11-21 21:26:42 UTC) #8
jianli
mostly looked good. I have concern that our OfflinePageTabObserver logic becomes more and more complicated ...
4 years, 1 month ago (2016-11-21 22:35:54 UTC) #11
jianli
lgtm
4 years, 1 month ago (2016-11-21 23:13:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520583002/20001
4 years, 1 month ago (2016-11-21 23:42:39 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-21 23:52:05 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 23:56:40 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b7c13b94eafad8d7458bde05ca6733eb11d731be
Cr-Commit-Position: refs/heads/master@{#433700}

Powered by Google App Engine
This is Rietveld 408576698