Make core libraries use generic method syntax.

sdk/lib/internal/iterable.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart._internal;
 
 /**
  * Marker interface for [Iterable] subclasses that have an efficient
  * [length] implementation.
  */
@@ skipping 154 matching lines @@
         if (length != this.length) {
           throw new ConcurrentModificationError(this);
         }
       }
       return buffer.toString();
     }
   }
 
   Iterable<E> where(bool test(E element)) => super.where(test);
 
-  Iterable/*<T>*/ map/*<T>*/(/*=T*/ f(E element)) =>
-      new MappedListIterable<E, dynamic/*=T*/ >(this, f);
+  Iterable<T> map<T>(T f(E element)) =>
+      new MappedListIterable<E, T >(this, f);
 
   E reduce(E combine(var value, E element)) {
     int length = this.length;
     if (length == 0) throw IterableElementError.noElement();
     E value = elementAt(0);
     for (int i = 1; i < length; i++) {
       value = combine(value, elementAt(i));
       if (length != this.length) {
         throw new ConcurrentModificationError(this);
       }
 
     }
     return value;
   }
 
-  /*=T*/ fold/*<T>*/(
-      var/*=T*/ initialValue, /*=T*/ combine(
-          var/*=T*/ previousValue, E element)) {
+  T fold<T>(

[floitsch, 2016/12/19 19:14:45]

should fit.

[Lasse Reichstein Nielsen, 2017/01/03 10:33:20]

Done.

+      T initialValue, T combine(
+          T previousValue, E element)) {
     var value = initialValue;
     int length = this.length;
     for (int i = 0; i < length; i++) {
       value = combine(value, elementAt(i));
       if (length != this.length) {
         throw new ConcurrentModificationError(this);
       }
     }
     return value;
   }
@@ skipping 216 matching lines @@
 
 class WhereIterable<E> extends Iterable<E> {
   final Iterable<E> _iterable;
   final _ElementPredicate<E> _f;
 
   WhereIterable(this._iterable, bool this._f(E element));
 
   Iterator<E> get iterator => new WhereIterator<E>(_iterable.iterator, _f);
 
   // Specialization of [Iterable.map] to non-EfficientLengthIterable.
-  Iterable/*<T>*/ map/*<T>*/(/*=T*/ f(E element)) =>
-     new MappedIterable<E, dynamic/*=T*/>._(this, f);
+  Iterable<T> map<T>(T f(E element)) =>
+     new MappedIterable<E, T>._(this, f);
 }
 
 class WhereIterator<E> extends Iterator<E> {
   final Iterator<E> _iterator;
   final _ElementPredicate _f;
 
   WhereIterator(this._iterator, bool this._f(E element));
 
   bool moveNext() {
     while (_iterator.moveNext()) {
@@ skipping 270 matching lines @@
 
   E singleWhere(bool test(E element), { E orElse() }) {
     if (orElse != null) return orElse();
     throw IterableElementError.noElement();
   }
 
   String join([String separator = ""]) => "";
 
   Iterable<E> where(bool test(E element)) => this;
 
-  Iterable/*<T>*/ map/*<T>*/(/*=T*/ f(E element)) => const EmptyIterable();
+  Iterable<T> map<T>(T f(E element)) => const EmptyIterable();
 
   E reduce(E combine(E value, E element)) {
     throw IterableElementError.noElement();
   }
 
-  /*=T*/ fold/*<T>*/(
-      var/*=T*/ initialValue, /*=T*/ combine(
-          var/*=T*/ previousValue, E element)) {
+  T fold<T>(

[floitsch, 2016/12/19 19:14:45]

should fit.

[Lasse Reichstein Nielsen, 2017/01/03 10:33:20]

Done.

+      T initialValue, T combine(
+          T previousValue, E element)) {
     return initialValue;
   }
 
   Iterable<E> skip(int count) {
     RangeError.checkNotNegative(count, "count");
     return this;
   }
 
   Iterable<E> skipWhile(bool test(E element)) => this;
 
@@ skipping 20 matching lines @@
  * Creates errors throw by [Iterable] when the element count is wrong.
  */
 abstract class IterableElementError {
   /** Error thrown thrown by, e.g., [Iterable.first] when there is no result. */
   static StateError noElement() => new StateError("No element");
   /** Error thrown by, e.g., [Iterable.single] if there are too many results. */
   static StateError tooMany() => new StateError("Too many elements");
   /** Error thrown by, e.g., [List.setRange] if there are too few elements. */
   static StateError tooFew() => new StateError("Too few elements");
 }