third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.cpp - Issue 2529293012: Invalidate paint properties on paint offset changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.cpp

Issue 2529293012: Invalidate paint properties on paint offset changes (Closed)

Patch Set: Fix transform underinvalidation, skip several spinvalidation skips Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.cpp

index ca7a99a6d1ff0009fa115671e74ac18adec7d023..a7438c2f6a0eb5a13542a7eaae594d6b26b611df 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.cpp

@@ -66,6 +66,11 @@ void LayoutSVGViewportContainer::calcViewport() {

void LayoutSVGViewportContainer::setNeedsTransformUpdate() {

setMayNeedPaintInvalidationSubtree();

+ if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled()) {

+ // The transform paint property relies on the SVG transform being up-to-date

+ // (see: PaintPropertyTreeBuilder::updateTransformForNonRootSVG).

+ setNeedsPaintPropertyUpdate();

+ }

m_needsTransformUpdate = true;

}