third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp - Issue 2529293012: Invalidate paint properties on paint offset changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp

Issue 2529293012: Invalidate paint properties on paint offset changes (Closed)

Patch Set: Fix transform underinvalidation, skip several spinvalidation skips Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp

index 9ce3b01a0e1ed8c65df73d84ace9bab582444e81..8d1af96c79bd28dcf912a58f18c4695c8e8f6268 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp

@@ -67,6 +67,11 @@ bool LayoutSVGTransformableContainer::isChildAllowed(

void LayoutSVGTransformableContainer::setNeedsTransformUpdate() {

setMayNeedPaintInvalidationSubtree();

+ if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled()) {

+ // The transform paint property relies on the SVG transform being up-to-date

+ // (see: PaintPropertyTreeBuilder::updateTransformForNonRootSVG).

+ setNeedsPaintPropertyUpdate();

+ }

m_needsTransformUpdate = true;

}