Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2529293004: [heap] Reland: Use store buffer for writes coming from mutator. (Closed)

Created:
4 years ago by Hannes Payer (out of office)
Modified:
4 years ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland: Use store buffer for writes coming from mutator. This reverts commit 061c2ab23a1d4cd192b935e7912e7dfb1fed845d. BUG=chromium:648568, chromium:669270 Committed: https://crrev.com/fa2fdf275197185d9bca9d5e72c16a60722c3893 Cr-Commit-Position: refs/heads/master@{#41341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -19 lines) Patch
M src/heap/heap.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/heap/heap-inl.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/heap/store-buffer.h View 3 chunks +19 lines, -1 line 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +21 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Hannes Payer (out of office)
4 years ago (2016-11-29 08:46:06 UTC) #5
Michael Lippautz
lgtm
4 years ago (2016-11-29 08:46:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529293004/1
4 years ago (2016-11-29 09:01:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529293004/1
4 years ago (2016-11-29 09:18:56 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 09:32:20 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fa2fdf275197185d9bca9d5e72c16a60722c3893 Cr-Commit-Position: refs/heads/master@{#41341}
4 years ago (2016-11-29 09:32:46 UTC) #17
Michael Achenbach
4 years ago (2016-11-29 10:02:07 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2534803004/ by machenbach@chromium.org.

The reason for reverting is: Suspect for tsan failures:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/12915.

Powered by Google App Engine
This is Rietveld 408576698