Chromium Code Reviews| Index: src/arm/codegen-arm.cc |
| diff --git a/src/arm/codegen-arm.cc b/src/arm/codegen-arm.cc |
| index e80bac47dccb6aeef1e381716924a9986a7ad56a..0367926dfa849758a95a542cae27486b235357f7 100644 |
| --- a/src/arm/codegen-arm.cc |
| +++ b/src/arm/codegen-arm.cc |
| @@ -440,31 +440,25 @@ bool Code::IsYoungSequence(Isolate* isolate, byte* sequence) { |
| return result; |
| } |
| - |
| -void Code::GetCodeAgeAndParity(Isolate* isolate, byte* sequence, Age* age, |
| - MarkingParity* parity) { |
| +Code::Age Code::GetCodeAge(Isolate* isolate, byte* sequence) { |
| if (IsYoungSequence(isolate, sequence)) { |
| - *age = kNoAgeCodeAge; |
| - *parity = NO_MARKING_PARITY; |
| + return kNoAgeCodeAge; |
| } else { |
|
Hannes Payer (out of office)
2016/11/28 09:49:10
Remove the else case (also in the other codegen-*
rmcilroy
2016/11/28 10:06:24
Not sure what you mean by this. I can't remove the
rmcilroy
2016/11/29 11:42:02
Done.
|
| Address target_address = Memory::Address_at( |
| sequence + (kNoCodeAgeSequenceLength - Assembler::kInstrSize)); |
| Code* stub = GetCodeFromTargetAddress(target_address); |
| - GetCodeAgeAndParity(stub, age, parity); |
| + return GetAgeOfCodeAgeStub(stub); |
| } |
| } |
| - |
| -void Code::PatchPlatformCodeAge(Isolate* isolate, |
| - byte* sequence, |
| - Code::Age age, |
| - MarkingParity parity) { |
| +void Code::PatchPlatformCodeAge(Isolate* isolate, byte* sequence, |
| + Code::Age age) { |
| uint32_t young_length = isolate->code_aging_helper()->young_sequence_length(); |
| if (age == kNoAgeCodeAge) { |
| isolate->code_aging_helper()->CopyYoungSequenceTo(sequence); |
| Assembler::FlushICache(isolate, sequence, young_length); |
| } else { |
| - Code* stub = GetCodeAgeStub(isolate, age, parity); |
| + Code* stub = GetCodeAgeStub(isolate, age); |
| CodePatcher patcher(isolate, sequence, |
| young_length / Assembler::kInstrSize); |
| patcher.masm()->add(r0, pc, Operand(-8)); |
| @@ -473,7 +467,6 @@ void Code::PatchPlatformCodeAge(Isolate* isolate, |
| } |
| } |
| - |
| } // namespace internal |
| } // namespace v8 |