Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2529073002: No longer store page logical height in LayoutState. (Closed)

Created:
4 years ago by mstensho (USE GERRIT)
Modified:
4 years ago
Reviewers:
szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

No longer store page logical height in LayoutState. That height may not be uniform throughout the entire fragmentation context anyway, so it's not reliable to do it like this. For multicol, the value was only used as a flag (0=unknown height, 1=known height). Move calculation of available column height to LayoutMultiColumnFlowThread. It no longer needs to live in LayoutBlockFlow. Committed: https://crrev.com/058f4df429bfb332c6bf8ae9a759700072bdc839 Cr-Commit-Position: refs/heads/master@{#434965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -71 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 5 chunks +3 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 2 chunks +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.h View 3 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.cpp View 3 chunks +4 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
mstensho (USE GERRIT)
4 years ago (2016-11-25 14:17:01 UTC) #4
szager1
lgtm, nice cleanup
4 years ago (2016-11-29 00:55:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529073002/1
4 years ago (2016-11-29 11:45:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 12:58:17 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-29 12:59:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/058f4df429bfb332c6bf8ae9a759700072bdc839
Cr-Commit-Position: refs/heads/master@{#434965}

Powered by Google App Engine
This is Rietveld 408576698