Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutState.h

Issue 2529073002: No longer store page logical height in LayoutState. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutState.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutState.h b/third_party/WebKit/Source/core/layout/LayoutState.h
index b892d73088c3ff3242c638cefbb3b05c74deba45..b666ec43515371615e0b34550eeff7a91864ec09 100644
--- a/third_party/WebKit/Source/core/layout/LayoutState.h
+++ b/third_party/WebKit/Source/core/layout/LayoutState.h
@@ -67,13 +67,11 @@ class LayoutState {
public:
// Constructor for root LayoutState created by LayoutView
- LayoutState(LayoutUnit pageLogicalHeight,
- LayoutView&);
+ explicit LayoutState(LayoutView&);
// Constructor for sub-tree layout and orthogonal writing-mode roots
explicit LayoutState(LayoutObject& root);
LayoutState(LayoutBox&,
- LayoutUnit pageLogicalHeight = LayoutUnit(),
bool containingBlockLogicalWidthChanged = false);
~LayoutState();
@@ -94,7 +92,6 @@ class LayoutState {
};
const LayoutSize& paginationOffset() const { return m_paginationOffset; }
- LayoutUnit pageLogicalHeight() const { return m_pageLogicalHeight; }
bool containingBlockLogicalWidthChanged() const {
return m_containingBlockLogicalWidthChanged;
}
@@ -124,9 +121,6 @@ class LayoutState {
// relative positioning or scroll offsets.
LayoutSize m_paginationOffset;
- // The current page height for the pagination model that encloses us.
- LayoutUnit m_pageLogicalHeight;
-
// The height we need to make available for repeating table headers in
// paginated layout.
LayoutUnit m_heightOffsetForTableHeaders;

Powered by Google App Engine
This is Rietveld 408576698