Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

Issue 2528823002: Separate SwipeRefreshHandler and ContentViewCore (Closed)
Patch Set: Eliminate native SwipeRefreshHandler. Now we just pass around a Java reference in native code. Atta… Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
index 2803d37f91dad0afd556110c621b488b1f9babc3..2ee1ab1620ac90a85d08fdf1b11221a51a616c1a 100644
--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
@@ -19,6 +19,7 @@ import org.chromium.base.annotations.JNINamespace;
import org.chromium.content.browser.AppWebMessagePort;
import org.chromium.content.browser.AppWebMessagePortService;
import org.chromium.content.browser.MediaSessionImpl;
+import org.chromium.content.browser.OverscrollRefreshHandler;
import org.chromium.content_public.browser.AccessibilitySnapshotCallback;
import org.chromium.content_public.browser.AccessibilitySnapshotNode;
import org.chromium.content_public.browser.ContentBitmapCallback;
@@ -421,8 +422,13 @@ import java.util.UUID;
}
@Override
- public void getContentBitmapAsync(Bitmap.Config config, float scale, Rect srcRect,
- ContentBitmapCallback callback) {
+ public void setOverscrollRefreshHandler(OverscrollRefreshHandler handler) {
+ nativeSetOverscrollRefreshHandler(mNativeWebContentsAndroid, handler);
+ }
+
+ @Override
+ public void getContentBitmapAsync(
+ Bitmap.Config config, float scale, Rect srcRect, ContentBitmapCallback callback) {
nativeGetContentBitmap(mNativeWebContentsAndroid, callback, config, scale,
srcRect.left, srcRect.top, srcRect.width(), srcRect.height());
}
@@ -533,6 +539,8 @@ import java.util.UUID;
private native int nativeGetThemeColor(long nativeWebContentsAndroid);
private native void nativeRequestAccessibilitySnapshot(
long nativeWebContentsAndroid, AccessibilitySnapshotCallback callback);
+ private native void nativeSetOverscrollRefreshHandler(
+ long nativeWebContentsAndroid, OverscrollRefreshHandler nativeOverscrollRefreshHandler);
private native void nativeGetContentBitmap(long nativeWebContentsAndroid,
ContentBitmapCallback callback, Bitmap.Config config, float scale,
float x, float y, float width, float height);

Powered by Google App Engine
This is Rietveld 408576698