ui/android/BUILD.gn - Issue 2528823002: Separate SwipeRefreshHandler and ContentViewCore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/android/BUILD.gn

Issue 2528823002: Separate SwipeRefreshHandler and ContentViewCore (Closed)

Patch Set: Eliminate native SwipeRefreshHandler. Now we just pass around a Java reference in native code. Atta… Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/android/BUILD.gn

diff --git a/ui/android/BUILD.gn b/ui/android/BUILD.gn

index d75680cd2feba64655832a81f4cccd15c8380550..13f897b7dc36ea2c83455d5f11a313b4f89c842e 100644

--- a/ui/android/BUILD.gn

+++ b/ui/android/BUILD.gn

@@ -76,6 +76,7 @@ static_library("test_support") {

generate_jni("ui_android_jni_headers") {

sources = [

+ "../../chrome/android/java/src/org/chromium/chrome/browser/SwipeRefreshHandler.java",

rlanday 2016/11/30 00:18:33 Is this acceptable? Referencing a Java file in ano

Jinsuk Kim 2016/11/30 01:59:21 It's a layering violation, and not acceptable. Thi

"java/src/org/chromium/ui/base/ViewAndroidDelegate.java",

"java/src/org/chromium/ui/base/WindowAndroid.java",

"java/src/org/chromium/ui/display/DisplayAndroidManager.java",