Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 2528813002: Fix Self-Referencing OOPIF Infinite Loop (Closed)
Patch Set: add fix to find and renderframe tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index 20a159af380b79c8a118d88c4fd31c9f2f599a1d..b2f9b27c42906cedfda49896f2b135b041359784 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -223,6 +223,10 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
RequestContextType request_context_type,
const ThrottleChecksFinishedCallback& callback);
+ // Prevents navigation to a page that is already referenced more than once in
+ // its ancestors
alexmos 2016/12/28 00:25:59 nit: end with period.
alexmos 2016/12/28 00:25:59 This comment isn't entirely accurate, as it only t
davidsac (gone - try alexmos) 2017/01/06 00:44:57 Done.
davidsac (gone - try alexmos) 2017/01/06 00:44:57 Done.
+ bool isURLBlocked();
alexmos 2016/12/28 00:25:59 Let's use a name that conveys what specific check
alexmos 2016/12/28 00:25:59 Let's not insert this in between WillStartRequest
davidsac (gone - try alexmos) 2017/01/06 00:44:57 Done.
davidsac (gone - try alexmos) 2017/01/06 00:44:57 Done.
+
// Called when the URLRequest will be redirected in the network stack.
// |callback| will be called when all throttles check have completed. This
// will allow the caller to cancel the navigation or let it proceed.

Powered by Google App Engine
This is Rietveld 408576698