Fix Self-Referencing OOPIF Infinite Loop

content/browser/frame_host/navigation_handle_impl.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
 
 #include "content/public/browser/navigation_handle.h"
 
 #include <stddef.h>
@@ skipping 205 matching lines @@
   void WillStartRequest(
       const std::string& method,
       scoped_refptr<content::ResourceRequestBodyImpl> resource_request_body,
       const Referrer& sanitized_referrer,
       bool has_user_gesture,
       ui::PageTransition transition,
       bool is_external_protocol,
       RequestContextType request_context_type,
       const ThrottleChecksFinishedCallback& callback);
 
+  // Prevents navigation to a page that is already referenced more than once in
+  // its ancestors

[alexmos, 2016/12/28 00:25:59]

nit: end with period.

[alexmos, 2016/12/28 00:25:59]

This comment isn't entirely accurate, as it only tells whether the navigation
URL is referenced in ancestors, but it doesn't actually prevent the navigation. 
Perhaps just tweak the wording to say that this is a helper function that's used
by WillStartRequest and WillRedirectRequest to prevent the navigation?

[davidsac (gone - try alexmos), 2017/01/06 00:44:57]

Done.

[davidsac (gone - try alexmos), 2017/01/06 00:44:57]

Done.

+  bool isURLBlocked();

[alexmos, 2016/12/28 00:25:59]

Let's use a name that conveys what specific check is done here.  For example,
IsSelfReferentialURL.

[alexmos, 2016/12/28 00:25:59]

Let's not insert this in between WillStartRequest and WillRedirectRequest, which
make sense to keep next to each other.  Also, can this be private, as it's not
really intended to be used outside of here?  So for example this could go just
after RegisterNavigationThrottles(), here and in in .cc to match header order.

[davidsac (gone - try alexmos), 2017/01/06 00:44:57]

Done.

[davidsac (gone - try alexmos), 2017/01/06 00:44:57]

Done.

+
   // Called when the URLRequest will be redirected in the network stack.
   // |callback| will be called when all throttles check have completed. This
   // will allow the caller to cancel the navigation or let it proceed.
   // This will also inform the delegate that the request was redirected.
   void WillRedirectRequest(
       const GURL& new_url,
       const std::string& new_method,
       const GURL& new_referrer_url,
       bool new_is_external_protocol,
       scoped_refptr<net::HttpResponseHeaders> response_headers,
@@ skipping 208 matching lines @@
   std::string searchable_form_encoding_;
 
   base::WeakPtrFactory<NavigationHandleImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationHandleImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_