VM: [Kernel] Relax assertion in SSA construction.

VM: [Kernel] Relax assertions in SSA construction and in Kernel loading.

- Kernel-to-IL translation leaves behind some unused constants without temp indices assigned.

- Let compile time errors propagate instead of failing with FATAL error in the post load class finalization.

R=kustermann@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/73ef820ec171ea070abf1da5ba28aa0560d1d069

[Vyacheslav Egorov (Google), 2016-11-23 20:32:44]

Description was changed from

==========
VM: [Kernel] Relax assertion in SSA construction.

Kernel-to-IL translation leaves behind some unused constants without temp
indices assinged.

R=kustermann@google.com
BUG=
==========

to

==========
VM: [Kernel] Relax assertions in SSA construction and in Kernel loading.

- Kernel-to-IL translation leaves behind some unused constants without temp
indices assigned.

- Let compile time errors propagate instead of failing with FATAL error in the
post load class finalization.

R=kustermann@google.com
BUG=
==========

[kustermann, 2016-11-24 12:16:49]

lgtm

https://codereview.chromium.org/2528763002/diff/1/runtime/vm/kernel_reader.cc
File runtime/vm/kernel_reader.cc (right):

https://codereview.chromium.org/2528763002/diff/1/runtime/vm/kernel_reader.cc...
runtime/vm/kernel_reader.cc:127:
ClassFinalizer::ProcessPendingClasses(/*from_kernel=*/true);
I'm not sure I completely understand why we ignore the return value. Is a return
value of `false` a compile-time error? If so, shouldn't we do a

  H.ReportError("Failed to finalize classes due to compile-time error")

Which will be caught by the setjmp() else branch?

In any case, maybe add a comment about it here.

[Vyacheslav Egorov (Google), 2016-11-24 15:19:25]

Description was changed from

==========
VM: [Kernel] Relax assertions in SSA construction and in Kernel loading.

- Kernel-to-IL translation leaves behind some unused constants without temp
indices assigned.

- Let compile time errors propagate instead of failing with FATAL error in the
post load class finalization.

R=kustermann@google.com
BUG=
==========

to

==========
VM: [Kernel] Relax assertions in SSA construction and in Kernel loading.

- Kernel-to-IL translation leaves behind some unused constants without temp
indices assigned.

- Let compile time errors propagate instead of failing with FATAL error in the
post load class finalization.

R=kustermann@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/73ef820ec171ea070abf1da5ba28aa0560d1d069
==========

[Vyacheslav Egorov (Google), 2016-11-24 15:19:26]

Committed patchset #1 (id:1) manually as
73ef820ec171ea070abf1da5ba28aa0560d1d069 (presubmit successful).