VM: [Kernel] Relax assertion in SSA construction.

runtime/vm/kernel_reader.cc

Index: runtime/vm/kernel_reader.cc
diff --git a/runtime/vm/kernel_reader.cc b/runtime/vm/kernel_reader.cc
index cbecd512ea59bf9bbf1a1077525d368e351e3ca7..0a11842b6966c535a08c30221ccb926776d83b60 100644
--- a/runtime/vm/kernel_reader.cc
+++ b/runtime/vm/kernel_reader.cc
@@ -124,9 +124,7 @@ Object& KernelReader::ReadProgram() {
       if (!library.Loaded()) library.SetLoaded();
     }
 
-    if (!ClassFinalizer::ProcessPendingClasses(/*from_kernel=*/true)) {
-      FATAL("Error in class finalization during bootstrapping.");
-    }
+    ClassFinalizer::ProcessPendingClasses(/*from_kernel=*/true);

[kustermann, 2016/11/24 12:16:49]

I'm not sure I completely understand why we ignore the return value. Is a return
value of `false` a compile-time error? If so, shouldn't we do a

  H.ReportError("Failed to finalize classes due to compile-time error")

Which will be caught by the setjmp() else branch?

In any case, maybe add a comment about it here.

 
     dart::Library& library = LookupLibrary(kernel_main_library);