Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3487)

Unified Diff: services/shape_detection/BUILD.gn

Issue 2528743002: Shape Detection: Implement FaceDetection on Mac as out-of-process service (Closed)
Patch Set: Add explanatory comments, rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/shape_detection/BUILD.gn
diff --git a/services/shape_detection/BUILD.gn b/services/shape_detection/BUILD.gn
new file mode 100644
index 0000000000000000000000000000000000000000..769b615fb8c696098f7e88d797945a787a422589
--- /dev/null
+++ b/services/shape_detection/BUILD.gn
@@ -0,0 +1,45 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("//services/service_manager/public/cpp/service.gni")
+import("//services/service_manager/public/service_manifest.gni")
+
+source_set("lib") {
+ sources = [
+ "face_detection_impl.cc",
+ "face_detection_impl.h",
+ "shape_detection_service.cc",
+ "shape_detection_service.h",
+ ]
+
+ if (is_mac) {
+ sources -= [ "face_detection_impl.cc" ]
+ sources += [
+ "face_detection_impl_mac.h",
+ "face_detection_impl_mac.mm",
+ ]
+ }
Ken Rockot(use gerrit already) 2016/12/05 20:56:52 nit: Instead of subtracting face_detection_impl.cc
xianglu 2016/12/05 22:13:22 Done.
+
+ deps = [
+ "//base",
+ "//mojo/public/cpp/bindings",
+ "//ui/gfx",
+ "//ui/gfx/geometry",
+ ]
+
+ public_deps = [
Ken Rockot(use gerrit already) 2016/12/05 20:56:52 nit: //base should be in public_deps too (technica
xianglu 2016/12/05 22:13:22 Done.
+ "//services/service_manager/public/cpp",
+ "//services/shape_detection/public/interfaces",
+ "//third_party/WebKit/public:mojo_bindings",
+ ]
+
+ data_deps = [
+ ":manifest",
+ ]
+}
+
+service_manifest("manifest") {
+ name = "shape_detection"
+ source = "manifest.json"
+}

Powered by Google App Engine
This is Rietveld 408576698