Shape Detection: Implement FaceDetection on Mac as out-of-process service

services/shape_detection/BUILD.gn

+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("//services/service_manager/public/cpp/service.gni")
+import("//services/service_manager/public/service_manifest.gni")
+
+source_set("lib") {
+  sources = [
+    "face_detection_impl.cc",
+    "face_detection_impl.h",
+    "shape_detection_service.cc",
+    "shape_detection_service.h",
+  ]
+
+  if (is_mac) {
+    sources -= [ "face_detection_impl.cc" ]
+    sources += [
+      "face_detection_impl_mac.h",
+      "face_detection_impl_mac.mm",
+    ]
+  }

[Ken Rockot(use gerrit already), 2016/12/05 20:56:52]

nit: Instead of subtracting face_detection_impl.cc here and always adding it
above, how about only adding it in an else block here?

[xianglu, 2016/12/05 22:13:22]

Done.

+
+  deps = [
+    "//base",
+    "//mojo/public/cpp/bindings",
+    "//ui/gfx",
+    "//ui/gfx/geometry",
+  ]
+
+  public_deps = [

[Ken Rockot(use gerrit already), 2016/12/05 20:56:52]

nit: //base should be in public_deps too (technically only needed on mac but i
see no point in making a distinction)

[xianglu, 2016/12/05 22:13:22]

Done.

+    "//services/service_manager/public/cpp",
+    "//services/shape_detection/public/interfaces",
+    "//third_party/WebKit/public:mojo_bindings",
+  ]
+
+  data_deps = [
+    ":manifest",
+  ]
+}
+
+service_manifest("manifest") {
+  name = "shape_detection"
+  source = "manifest.json"
+}