Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: content/browser/browser_context.cc

Issue 2528743002: Shape Detection: Implement FaceDetection on Mac as out-of-process service (Closed)
Patch Set: Add explanatory comments, rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_context.cc
diff --git a/content/browser/browser_context.cc b/content/browser/browser_context.cc
index 8d54f02107576882c7e95aa261c9149219a57acb..ce89c8bf794e9c5ea7969ee70a581f2c3335bcb9 100644
--- a/content/browser/browser_context.cc
+++ b/content/browser/browser_context.cc
@@ -47,6 +47,8 @@
#include "services/service_manager/public/cpp/connection.h"
#include "services/service_manager/public/cpp/connector.h"
#include "services/service_manager/public/interfaces/service.mojom.h"
+#include "services/shape_detection/public/interfaces/constants.mojom.h"
+#include "services/shape_detection/shape_detection_service.h"
#include "storage/browser/database/database_tracker.h"
#include "storage/browser/fileapi/external_mount_points.h"
@@ -467,6 +469,16 @@ void BrowserContext::Initialize(
BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE));
connection->AddEmbeddedService(device::mojom::kServiceName, info);
+ // Shape Detection Service is in browser process for now. Because native
+ // Mac API |CIDetector| does GPU-previliged operations, and we don't have
Ken Rockot(use gerrit already) 2016/12/05 20:56:52 nit: s/previliged/privileged/
xianglu 2016/12/05 22:13:22 Done.
+ // full control over it, please consider moving it to a utility process if
+ // we see crashes in the future.
+ ServiceInfo shape_detection_info;
+ shape_detection_info.factory =
+ base::Bind(&shape_detection::ShapeDetectionService::Create);
+ connection->AddEmbeddedService(shape_detection::mojom::kServiceName,
+ shape_detection_info);
+
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kMojoLocalStorage)) {
ServiceInfo info;

Powered by Google App Engine
This is Rietveld 408576698