Shape Detection: Implement FaceDetection on Mac as out-of-process service

content/browser/browser_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/browser_context.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <algorithm>
 #include <limits>
@@ skipping 29 matching lines @@
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "services/device/device_service.h"
 #include "services/device/public/interfaces/constants.mojom.h"
 #include "services/file/file_service.h"
 #include "services/file/public/interfaces/constants.mojom.h"
 #include "services/file/user_id_map.h"
 #include "services/service_manager/public/cpp/connection.h"
 #include "services/service_manager/public/cpp/connector.h"
 #include "services/service_manager/public/interfaces/service.mojom.h"
+#include "services/shape_detection/public/interfaces/constants.mojom.h"
+#include "services/shape_detection/shape_detection_service.h"
 #include "storage/browser/database/database_tracker.h"
 #include "storage/browser/fileapi/external_mount_points.h"
 
 using base::UserDataAdapter;
 
 namespace content {
 
 namespace {
 
 base::LazyInstance<std::map<std::string, BrowserContext*>>
@@ skipping 400 matching lines @@
 
     // New embedded service factories should be added to |connection| here.
     // TODO(blundell): Does this belong as a global service rather than per
     // BrowserContext?
     ServiceInfo info;
     info.factory =
         base::Bind(&device::CreateDeviceService,
                    BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE));
     connection->AddEmbeddedService(device::mojom::kServiceName, info);
 
+    // Shape Detection Service is in browser process for now. Because native
+    // Mac API |CIDetector| does GPU-previliged operations, and we don't have

[Ken Rockot(use gerrit already), 2016/12/05 20:56:52]

nit: s/previliged/privileged/

[xianglu, 2016/12/05 22:13:22]

Done.

+    // full control over it, please consider moving it to a utility process if
+    // we see crashes in the future.
+    ServiceInfo shape_detection_info;
+    shape_detection_info.factory =
+        base::Bind(&shape_detection::ShapeDetectionService::Create);
+    connection->AddEmbeddedService(shape_detection::mojom::kServiceName,
+                                   shape_detection_info);
+
     if (base::CommandLine::ForCurrentProcess()->HasSwitch(
             switches::kMojoLocalStorage)) {
       ServiceInfo info;
       info.factory =
           base::Bind(&file::CreateFileService,
                      BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE),
                      BrowserThread::GetTaskRunnerForThread(BrowserThread::DB));
       connection->AddEmbeddedService(file::mojom::kServiceName, info);
     }
   }
@@ skipping 49 matching lines @@
   if (GetUserData(kDownloadManagerKeyName))
     GetDownloadManager(this)->Shutdown();
 }
 
 void BrowserContext::ShutdownStoragePartitions() {
   if (GetUserData(kStoragePartitionMapKeyName))
     RemoveUserData(kStoragePartitionMapKeyName);
 }
 
 }  // namespace content