Shape Detection: Implement FaceDetection on Mac as out-of-process service

content/browser/browser_context.cc

Index: content/browser/browser_context.cc
diff --git a/content/browser/browser_context.cc b/content/browser/browser_context.cc
index 8d54f02107576882c7e95aa261c9149219a57acb..425abf16968632be60b28e2358c095e5bad9f146 100644
--- a/content/browser/browser_context.cc
+++ b/content/browser/browser_context.cc
@@ -47,6 +47,8 @@
 #include "services/service_manager/public/cpp/connection.h"
 #include "services/service_manager/public/cpp/connector.h"
 #include "services/service_manager/public/interfaces/service.mojom.h"
+#include "services/shape_detection/public/interfaces/constants.mojom.h"
+#include "services/shape_detection/shape_detection_service.h"
 #include "storage/browser/database/database_tracker.h"
 #include "storage/browser/fileapi/external_mount_points.h"
 
@@ -467,6 +469,14 @@ void BrowserContext::Initialize(
                    BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE));
     connection->AddEmbeddedService(device::mojom::kServiceName, info);
 
+    // Shape Detection Service is in browser process for now. If we see crashes

[yzshen1, 2016/12/05 17:41:19]

 I feel that this comment is not very useful. Do we expect crashes to be
"normal" for this service?

[xianglu, 2016/12/05 18:50:02]

There have been different opinions on the process this service should live in.
Shape Detection is moved into //services/ mostly because we can easily plug it
into another process. I put the comment here as a reminder that this feature is
very experimental and we are open to moving the code around if necessary.

[yzshen1, 2016/12/05 19:38:29]

I mean, usually we don't consider crashes as something tolerable and should fix
them properly. I understand that we have exceptions such as the gpu process. But
I don't know whether this service falls in the same category.

It probably makes sense to add more context information why moving to a separate
process is a reasonable solution for addressing crashes, and maybe a bug link .

+    // in the future, consider moving it to a utility process.
+    ServiceInfo shape_detection_info;
+    shape_detection_info.factory =
+        base::Bind(&shape_detection::ShapeDetectionService::Create);
+    connection->AddEmbeddedService(shape_detection::mojom::kServiceName,
+                                   shape_detection_info);
+
     if (base::CommandLine::ForCurrentProcess()->HasSwitch(
             switches::kMojoLocalStorage)) {
       ServiceInfo info;