Shape Detection: Implement FaceDetection on Mac as out-of-process service

content/browser/browser_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/browser_context.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <algorithm>
 #include <limits>
@@ skipping 29 matching lines @@
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "services/device/device_service.h"
 #include "services/device/public/interfaces/constants.mojom.h"
 #include "services/file/file_service.h"
 #include "services/file/public/interfaces/constants.mojom.h"
 #include "services/file/user_id_map.h"
 #include "services/service_manager/public/cpp/connection.h"
 #include "services/service_manager/public/cpp/connector.h"
 #include "services/service_manager/public/interfaces/service.mojom.h"
+#include "services/shape_detection/public/interfaces/constants.mojom.h"
+#include "services/shape_detection/shape_detection_service.h"
 #include "storage/browser/database/database_tracker.h"
 #include "storage/browser/fileapi/external_mount_points.h"
 
 using base::UserDataAdapter;
 
 namespace content {
 
 namespace {
 
 base::LazyInstance<std::map<std::string, BrowserContext*>>
@@ skipping 400 matching lines @@
 
     // New embedded service factories should be added to |connection| here.
     // TODO(blundell): Does this belong as a global service rather than per
     // BrowserContext?
     ServiceInfo info;
     info.factory =
         base::Bind(&device::CreateDeviceService,
                    BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE));
     connection->AddEmbeddedService(device::mojom::kServiceName, info);
 
+    // Shape Detection Service is in browser process for now. If we see crashes

[yzshen1, 2016/12/05 17:41:19]

 I feel that this comment is not very useful. Do we expect crashes to be
"normal" for this service?

[xianglu, 2016/12/05 18:50:02]

There have been different opinions on the process this service should live in.
Shape Detection is moved into //services/ mostly because we can easily plug it
into another process. I put the comment here as a reminder that this feature is
very experimental and we are open to moving the code around if necessary.

[yzshen1, 2016/12/05 19:38:29]

I mean, usually we don't consider crashes as something tolerable and should fix
them properly. I understand that we have exceptions such as the gpu process. But
I don't know whether this service falls in the same category.

It probably makes sense to add more context information why moving to a separate
process is a reasonable solution for addressing crashes, and maybe a bug link .

+    // in the future, consider moving it to a utility process.
+    ServiceInfo shape_detection_info;
+    shape_detection_info.factory =
+        base::Bind(&shape_detection::ShapeDetectionService::Create);
+    connection->AddEmbeddedService(shape_detection::mojom::kServiceName,
+                                   shape_detection_info);
+
     if (base::CommandLine::ForCurrentProcess()->HasSwitch(
             switches::kMojoLocalStorage)) {
       ServiceInfo info;
       info.factory =
           base::Bind(&file::CreateFileService,
                      BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE),
                      BrowserThread::GetTaskRunnerForThread(BrowserThread::DB));
       connection->AddEmbeddedService(file::mojom::kServiceName, info);
     }
   }
@@ skipping 49 matching lines @@
   if (GetUserData(kDownloadManagerKeyName))
     GetDownloadManager(this)->Shutdown();
 }
 
 void BrowserContext::ShutdownStoragePartitions() {
   if (GetUserData(kStoragePartitionMapKeyName))
     RemoveUserData(kStoragePartitionMapKeyName);
 }
 
 }  // namespace content