Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2528733002:
Roll clang 287685:287780. (Closed)
|
Created:
4 years ago by Nico Modified:
4 years ago Reviewers:
Reid Kleckner CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll clang 287685:287780.
Ran `tools/clang/scripts/upload_revision.py 287780`.
Quick follow-up to https://codereview.chromium.org/2523073002, picks up fixes
for a PCH crash and for asan x86 dll builds.
BUG=667891, 668212
TBR=rnk
Committed: https://crrev.com/7dd55ef76fd36f1840677c3277ee0e598a50806a
Cr-Commit-Position: refs/heads/master@{#434386}
Patch Set 1 #
Messages
Total messages: 24 (19 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thakis@chromium.org changed reviewers: + rnk@chromium.org
Since it was so much fun yesteray. Picks up your pch and your asan/dll change.
Description was changed from ========== Roll clang 287685:287780. Ran `tools/clang/scripts/upload_revision.py 287780`. BUG= ========== to ========== Roll clang 287685:287780. Ran `tools/clang/scripts/upload_revision.py 287780`. Quick follow-up to https://codereview.chromium.org/2523073002, picks up fixes for a PCH crash and for asan x86 dll builds. BUG=667891,668212 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Roll clang 287685:287780. Ran `tools/clang/scripts/upload_revision.py 287780`. Quick follow-up to https://codereview.chromium.org/2523073002, picks up fixes for a PCH crash and for asan x86 dll builds. BUG=667891,668212 ========== to ========== Roll clang 287685:287780. Ran `tools/clang/scripts/upload_revision.py 287780`. Quick follow-up to https://codereview.chromium.org/2523073002, picks up fixes for a PCH crash and for asan x86 dll builds. BUG=667891,668212 TBR=rnk ==========
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480017841110490, "parent_rev":
"a2d53c344f7210e6ed5938a7d335b63d781eb92e", "commit_rev":
"8053302664033a31ee06eb962faabbabe92b4964"}
Message was sent while issue was closed.
Description was changed from ========== Roll clang 287685:287780. Ran `tools/clang/scripts/upload_revision.py 287780`. Quick follow-up to https://codereview.chromium.org/2523073002, picks up fixes for a PCH crash and for asan x86 dll builds. BUG=667891,668212 TBR=rnk ========== to ========== Roll clang 287685:287780. Ran `tools/clang/scripts/upload_revision.py 287780`. Quick follow-up to https://codereview.chromium.org/2523073002, picks up fixes for a PCH crash and for asan x86 dll builds. BUG=667891,668212 TBR=rnk ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll clang 287685:287780. Ran `tools/clang/scripts/upload_revision.py 287780`. Quick follow-up to https://codereview.chromium.org/2523073002, picks up fixes for a PCH crash and for asan x86 dll builds. BUG=667891,668212 TBR=rnk ========== to ========== Roll clang 287685:287780. Ran `tools/clang/scripts/upload_revision.py 287780`. Quick follow-up to https://codereview.chromium.org/2523073002, picks up fixes for a PCH crash and for asan x86 dll builds. BUG=667891,668212 TBR=rnk Committed: https://crrev.com/7dd55ef76fd36f1840677c3277ee0e598a50806a Cr-Commit-Position: refs/heads/master@{#434386} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7dd55ef76fd36f1840677c3277ee0e598a50806a Cr-Commit-Position: refs/heads/master@{#434386}
Message was sent while issue was closed.
lgtm Thanks for poking that on the weekend! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
