PaymentApp: Blink side of payment request event dispatching in service worker.

third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
index b3d1850adf7115988cb12ace8c85a4223eb20caa..8c4c4900b2bdbf4f993a515fa437756a655b0d7d 100644
--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
@@ -45,6 +45,9 @@
 #include "modules/notifications/Notification.h"
 #include "modules/notifications/NotificationEvent.h"
 #include "modules/notifications/NotificationEventInit.h"
+#include "modules/payments/PaymentAppRequestData.h"
+#include "modules/payments/PaymentAppRequestDataConversion.h"
+#include "modules/payments/PaymentRequestEvent.h"
 #include "modules/push_messaging/PushEvent.h"
 #include "modules/push_messaging/PushMessageData.h"
 #include "modules/serviceworkers/ExtendableEvent.h"
@@ -326,6 +329,21 @@ void ServiceWorkerGlobalScopeProxy::dispatchSyncEvent(
   workerGlobalScope()->dispatchExtendableEvent(event, observer);
 }
 
+void ServiceWorkerGlobalScopeProxy::dispatchPaymentRequestEvent(
+    int eventID,
+    const WebPaymentAppRequestData& webData) {
+  ScriptState::Scope scope(
+      workerGlobalScope()->scriptController()->getScriptState());

[haraken, 2016/12/01 08:24:27]

You need to check scriptState->contextIsValid() before entering the scope,
because the context may be already gone.

[haraken, 2016/12/01 08:24:27]

nhiroki@: I'm confused when SW should enter ScriptState::Scope.
dispatchPaymentRequestEvent, dispatchForeignFetchEvent and dispatchFetchEvent
are entering ScriptState::Scope, but other dispatchXXXEvents are not entering
ScriptState::Scope. Why?

[kinuko, 2016/12/01 13:01:52]

dispatchFetchEvent and dispatchForeignFetchEvent needs to enter
ScriptState::Scope because creating Response or Request requires it (see the
comment in Response.h and Request.h)-- that's my understanding.

[nhiroki, 2016/12/02 02:30:15]

Thank you for pointing this out. As kinuko mentioned, this would be for creating
Response or Request. I'll make a patch to add comment about it.

zino, could you remove this line because PaymentRequest doesn't create them?

[zino, 2016/12/02 03:13:49]

The toPaymentAppRequestData() is also using ScriptState internally.
Therefore, I'm not sure but shouldn't it enter the ScriptState?

haraken@, What should I do for landing this?
Removing this line? VS adding contextIsValid() check?
Please correct me :)

+  WaitUntilObserver* observer = WaitUntilObserver::create(
+      workerGlobalScope(), WaitUntilObserver::PaymentRequest, eventID);
+  Event* event = PaymentRequestEvent::create(
+      EventTypeNames::paymentrequest,
+      PaymentAppRequestDataConversion::toPaymentAppRequestData(
+          workerGlobalScope()->scriptController()->getScriptState(), webData),
+      observer);
+  workerGlobalScope()->dispatchExtendableEvent(event, observer);
+}
+
 bool ServiceWorkerGlobalScopeProxy::hasFetchEventHandler() {
   DCHECK(m_workerGlobalScope);
   return m_workerGlobalScope->hasEventListeners(EventTypeNames::fetch);