PaymentApp: Blink side of payment request event dispatching in service worker.

third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp

Index: third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp
index dbb9088e96442fa26d315d48ad5feb205d14c858..4ad5a30371ba7c60b916d7d2dabb60acecee4a22 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp
@@ -8,6 +8,13 @@
 
 namespace blink {
 
+PaymentRequestEvent* PaymentRequestEvent::create(
+    const AtomicString& type,
+    const PaymentAppRequestData& data,
+    WaitUntilObserver* observer) {
+  return new PaymentRequestEvent(type, data, observer);
+}
+
 PaymentRequestEvent::~PaymentRequestEvent() {}
 
 const AtomicString& PaymentRequestEvent::interfaceName() const {
@@ -15,7 +22,7 @@ const AtomicString& PaymentRequestEvent::interfaceName() const {
 }
 
 void PaymentRequestEvent::data(PaymentAppRequestData& data) const {

[haraken, 2016/12/01 08:24:27]

Why don't you return PaymentAppRequestData instead of using a reference?

[zino, 2016/12/02 03:13:49]

Maybe, we can't return PaymentAppRequestData because it is a dictionary type.
 -
https://cs.chromium.org/chromium/src/out/Debug/gen/blink/bindings/modules/v8/...

-  NOTIMPLEMENTED();
+  data = m_data;
 }
 
 void PaymentRequestEvent::respondWith(ScriptPromise) {
@@ -23,12 +30,13 @@ void PaymentRequestEvent::respondWith(ScriptPromise) {
 }
 
 DEFINE_TRACE(PaymentRequestEvent) {
+  visitor->trace(m_data);
   ExtendableEvent::trace(visitor);
 }
 
 PaymentRequestEvent::PaymentRequestEvent(const AtomicString& type,
                                          const PaymentAppRequestData& data,
                                          WaitUntilObserver* observer)
-    : ExtendableEvent(type, ExtendableEventInit(), observer) {}
+    : ExtendableEvent(type, ExtendableEventInit(), observer), m_data(data) {}
 
 }  // namespace blink