Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 252863002: Add pathops and capture stderr so we can get SkDebugf output. (Closed)

Created:
6 years, 7 months ago by jcgregorio
Modified:
6 years, 7 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add pathops and capture stderr so we can get SkDebugf output. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14402

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M experimental/webtry/templates/template.cpp View 4 chunks +5 lines, -1 line 0 comments Download
M experimental/webtry/webtry.go View 1 2 chunks +5 lines, -14 lines 0 comments Download
M gyp/webtry.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jcgregorio
6 years, 7 months ago (2014-04-28 13:02:55 UTC) #1
mtklein
https://codereview.chromium.org/252863002/diff/1/experimental/webtry/webtry.go File experimental/webtry/webtry.go (right): https://codereview.chromium.org/252863002/diff/1/experimental/webtry/webtry.go#newcode292 experimental/webtry/webtry.go:292: message += stdErr.String() Perhaps we should use the same ...
6 years, 7 months ago (2014-04-28 13:27:35 UTC) #2
jcgregorio
https://codereview.chromium.org/252863002/diff/1/experimental/webtry/webtry.go File experimental/webtry/webtry.go (right): https://codereview.chromium.org/252863002/diff/1/experimental/webtry/webtry.go#newcode292 experimental/webtry/webtry.go:292: message += stdErr.String() On 2014/04/28 13:27:36, mtklein wrote: > ...
6 years, 7 months ago (2014-04-28 13:39:36 UTC) #3
mtklein
On 2014/04/28 13:39:36, jcgregorio wrote: > https://codereview.chromium.org/252863002/diff/1/experimental/webtry/webtry.go > File experimental/webtry/webtry.go (right): > > https://codereview.chromium.org/252863002/diff/1/experimental/webtry/webtry.go#newcode292 > ...
6 years, 7 months ago (2014-04-28 14:25:09 UTC) #4
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 7 months ago (2014-04-28 14:34:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/252863002/20001
6 years, 7 months ago (2014-04-28 14:34:20 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 14:56:39 UTC) #7
Message was sent while issue was closed. 
Change committed as 14402

Powered by Google App Engine
This is Rietveld 408576698