Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2528613003:
Roll Clang to 0a306690. (Closed)
DescriptionRoll Clang to 0a306690.
Committed: https://pdfium.googlesource.com/pdfium/+/106e9a37050197936731d7f13354757dff21d57e
Patch Set 1 #Messages
Total messages: 15 (10 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll Clang to 0a306690. TBR=thakis@chromium.org ========== to ========== Roll Clang to 0a306690. Add IFWL_ListBox::IsMultiSelection() to fix the bad negation logic introduced in commit 058d2d6b. ==========
Description was changed from ========== Roll Clang to 0a306690. Add IFWL_ListBox::IsMultiSelection() to fix the bad negation logic introduced in commit 058d2d6b. ========== to ========== Roll Clang to 0a306690. Add CFWL_ListBox::IsMultiSelection() to fix the bad negation logic introduced in commit 058d2d6b. ==========
Description was changed from ========== Roll Clang to 0a306690. Add CFWL_ListBox::IsMultiSelection() to fix the bad negation logic introduced in commit 058d2d6b. ========== to ========== Roll Clang to 0a306690. ==========
Looks like this will go back to just a roll. I don't know why some of the trybots were building at an older revision.
lgtm (but the next one is already waiting: https://codereview.chromium.org/2528733002/)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
It'll be good to get this one in to catch more bugs. Looks like we probably won't need the next one right away.
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479948113634850, "parent_rev":
"2c489cc41023a40648dfde988d11b8ec2b66c7d0", "commit_rev":
"106e9a37050197936731d7f13354757dff21d57e"}
Message was sent while issue was closed.
Description was changed from ========== Roll Clang to 0a306690. ========== to ========== Roll Clang to 0a306690. Committed: https://pdfium.googlesource.com/pdfium/+/106e9a37050197936731d7f13354757dff21... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/106e9a37050197936731d7f13354757dff21... |
