Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2528563005:
Add deprecation messages for EME requestMediaKeySystemAccess features (Closed)
DescriptionAdd deprecation messages for EME requestMediaKeySystemAccess features
Add a deprecation message if both 'audioCapabilities' and
'videoCapabilities' passed to navigator.requestMediaKeySystemAccess()
are empty. Support for this non-standard configuration will be removed
in M58.
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/aG_QGiPErlE
BUG=616233
TEST=message logged with EME layout tests
Committed: https://crrev.com/e58fd5bea854bbf7f519f33bbee5c7f458475b3f
Cr-Commit-Position: refs/heads/master@{#439004}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : fix test (+rebase) #
Messages
Total messages: 37 (20 generated)
jrummell@chromium.org changed reviewers: + ddorwin@chromium.org, xhwang@chromium.org
PTAL.
LG. I think we need to go through the intent process for the new item. Please do the 56 => 58 in a separate CL so we can land and merge that ASAP.
thanks! what ddorwin@ said :)
Description was changed from ========== Update deprecation messages for EME requestMediaKeySystemAccess features Change the existing message to M58, and add a second deprecation message. BUG=605661,616233 TEST=messages logged with EME layout tests ========== to ========== Add deprecation messages for EME requestMediaKeySystemAccess features Add a deprecation message if both 'audioCapabilities' and 'videoCapabilities' passed to navigator.requestMediaKeySystemAccess() are empty. Support for this non-standard configuration will be removed in M58. BUG=616233 TEST=message logged with EME layout tests ==========
Updated. Since the deprecation message for codecs was updated separately, this now just adds the deprecation message for missing capabilities. Sent intent message to blink-dev earlier today.
lgtm
jrummell@chromium.org changed reviewers: + foolip@chromium.org
+foolip@ for OWNERS review of Deprecation.cpp
The CQ bit was checked by foolip@chromium.org to run a CQ dry run
Started a dry run, if "TEST=message logged with EME layout tests" is true there should be some failures. Can you link to the intent in the description itself? lgtm to land when you have 3xLGTM on blink-dev.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== Add deprecation messages for EME requestMediaKeySystemAccess features Add a deprecation message if both 'audioCapabilities' and 'videoCapabilities' passed to navigator.requestMediaKeySystemAccess() are empty. Support for this non-standard configuration will be removed in M58. BUG=616233 TEST=message logged with EME layout tests ========== to ========== Add deprecation messages for EME requestMediaKeySystemAccess features Add a deprecation message if both 'audioCapabilities' and 'videoCapabilities' passed to navigator.requestMediaKeySystemAccess() are empty. Support for this non-standard configuration will be removed in M58. https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/aG_QGiPErlE BUG=616233 TEST=message logged with EME layout tests ==========
On 2016/12/08 20:44:48, foolip (OOO Dec. 9) wrote: > Started a dry run, if "TEST=message logged with EME layout tests" is true there > should be some failures. run_layout_tests.sh doesn't consider "CONSOLE WARNING" messages as failures. However, running "out/Debug/content_shell --run-layout-test media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html" locally logs the new message. > Can you link to the intent in the description itself? Done. > lgtm to land when you have 3xLGTM on blink-dev. Is there anything I need to do to encourage this, or simply wait for people to respond?
foolip@: According to https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OBglEqQtF94, I won't be getting any responses to my intent to implement. Your previous message stated I needed to get 3 approvals. Does this meet your expectations, or do I need to send something else (like an intent to deprecate message, although going through the chromestatus page to create an entry told me to post it as intent to implement).
On 2016/12/13 00:35:10, jrummell wrote: > foolip@: According to > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OBglEqQtF94, I > won't be getting any responses to my intent to implement. Your previous message > stated I needed to get 3 approvals. Does this meet your expectations, or do I > need to send something else (like an intent to deprecate message, although going > through the chromestatus page to create an entry told me to post it as intent to > implement). I think the problem here is that https://groups.google.com/a/chromium.org/d/msg/blink-dev/aG_QGiPErlE/mTRfxvgs... isn't quite an Intent to Implement, but more like an Intent to Deprecate and Remove. At least I think so, if the whole change is to make this code path throw an exception or otherwise fail. I'll comment on blink-dev.
The CQ bit was checked by jrummell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by jrummell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I've updated this CL with changes to old-powerful-features-on-insecure-origin.html as it calls requestMediaKeySystemAccess with an empty configuration.
still lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jrummell@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org Link to the patchset: https://codereview.chromium.org/2528563005/#ps60001 (title: "fix test (+rebase)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481852991245020,
"parent_rev": "3508d244e1728f26ad7bb9171ab49f76c0949642", "commit_rev":
"f0448935d5643a00566b87303f884acbeabda451"}
Message was sent while issue was closed.
Description was changed from ========== Add deprecation messages for EME requestMediaKeySystemAccess features Add a deprecation message if both 'audioCapabilities' and 'videoCapabilities' passed to navigator.requestMediaKeySystemAccess() are empty. Support for this non-standard configuration will be removed in M58. https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/aG_QGiPErlE BUG=616233 TEST=message logged with EME layout tests ========== to ========== Add deprecation messages for EME requestMediaKeySystemAccess features Add a deprecation message if both 'audioCapabilities' and 'videoCapabilities' passed to navigator.requestMediaKeySystemAccess() are empty. Support for this non-standard configuration will be removed in M58. https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/aG_QGiPErlE BUG=616233 TEST=message logged with EME layout tests Review-Url: https://codereview.chromium.org/2528563005 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add deprecation messages for EME requestMediaKeySystemAccess features Add a deprecation message if both 'audioCapabilities' and 'videoCapabilities' passed to navigator.requestMediaKeySystemAccess() are empty. Support for this non-standard configuration will be removed in M58. https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/aG_QGiPErlE BUG=616233 TEST=message logged with EME layout tests Review-Url: https://codereview.chromium.org/2528563005 ========== to ========== Add deprecation messages for EME requestMediaKeySystemAccess features Add a deprecation message if both 'audioCapabilities' and 'videoCapabilities' passed to navigator.requestMediaKeySystemAccess() are empty. Support for this non-standard configuration will be removed in M58. https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/aG_QGiPErlE BUG=616233 TEST=message logged with EME layout tests Committed: https://crrev.com/e58fd5bea854bbf7f519f33bbee5c7f458475b3f Cr-Commit-Position: refs/heads/master@{#439004} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/e58fd5bea854bbf7f519f33bbee5c7f458475b3f Cr-Commit-Position: refs/heads/master@{#439004} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
