Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceEntry.h

Issue 2528513003: first-paint and first-contentful paint (Closed)
Patch Set: Got rid of DCHECK cause it breaks unit tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceEntry.h
diff --git a/third_party/WebKit/Source/core/timing/PerformanceEntry.h b/third_party/WebKit/Source/core/timing/PerformanceEntry.h
index 06e7a923ccc65bb9dc3a3f30e829acbfd08cc6d0..e3b75748617f6286a07b57ba6b46d3d9cbec66a3 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceEntry.h
+++ b/third_party/WebKit/Source/core/timing/PerformanceEntry.h
@@ -44,8 +44,8 @@ class ScriptState;
class ScriptValue;
class V8ObjectBuilder;
-using PerformanceEntryType = unsigned char;
-using PerformanceEntryTypeMask = unsigned char;
+using PerformanceEntryType = unsigned;
+using PerformanceEntryTypeMask = unsigned;
class CORE_EXPORT PerformanceEntry
: public GarbageCollectedFinalized<PerformanceEntry>,
@@ -55,7 +55,7 @@ class CORE_EXPORT PerformanceEntry
public:
virtual ~PerformanceEntry();
- enum EntryType {
+ enum EntryType : PerformanceEntryType {
Invalid = 0,
Navigation = 1 << 0,
Composite = 1 << 1,
@@ -65,6 +65,7 @@ class CORE_EXPORT PerformanceEntry
Resource = 1 << 5,
LongTask = 1 << 6,
TaskAttribution = 1 << 7,
+ Paint = 1 << 8
};
String name() const;
@@ -87,7 +88,7 @@ class CORE_EXPORT PerformanceEntry
return a->startTime() < b->startTime();
}
- static EntryType toEntryTypeEnum(const String& entryType);
+ static PerformanceEntry::EntryType toEntryTypeEnum(const String& entryType);
DEFINE_INLINE_VIRTUAL_TRACE() {}
« no previous file with comments | « third_party/WebKit/Source/core/timing/PerformanceBase.cpp ('k') | third_party/WebKit/Source/core/timing/PerformanceEntry.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698