Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Unified Diff: tools/metrics/actions/actions.xml

Issue 2528303003: [NTP] Fixed usage of NewTabPage.ActionAndroid histogram (Closed)
Patch Set: Addressing comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index 0961d3827d7deb6823d0f025780644702c356092..b4fa25e9181cd2e4163c30cb115543ce1e6f55e3 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -9199,6 +9199,13 @@ should be able to be added at any place in this file.
</description>
</action>
+<action name="MobileBookmarkOpen">
+ <owner>ianwen@chromium.org</owner>
+ <description>
+ Action indicating the user has opened a bookmark from the bookmark manager.
Mark P 2016/12/21 18:13:13 optional nit (general advice; I see it doesn't agr
finkm 2016/12/22 09:45:44 Done
+ </description>
+</action>
+
<action name="MobileBreakpadUploadAttempt" not_user_triggered="true">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
@@ -9400,6 +9407,14 @@ should be able to be added at any place in this file.
<obsolete>Deprecated as of 12/2015</obsolete>
</action>
+<action name="MobileForeignSessionOpen">
+ <owner>finkm@chromium.org</owner>
+ <description>
+ Action indicating the user has opened a foreign session from the recent tabs
Mark P 2016/12/21 18:13:13 nit: "foreign session" is generally only a term th
finkm 2016/12/22 09:45:44 Done
+ manager.
+ </description>
+</action>
+
<action name="MobileFre.SignInShown">
<owner>aruslan@chromium.org</owner>
<description>
@@ -9691,6 +9706,7 @@ should be able to be added at any place in this file.
<description>
Action indicating the user has opened a bookmark from the bookmark manager.
</description>
+ <obsolete>Deprecated as of 11/2016</obsolete>
Mark P 2016/12/21 18:13:13 Please check to see whether this action is emitted
finkm 2016/12/22 09:45:44 You're right. It's still used in iOS. I removed th
</action>
<action name="MobileNTPForeignSession">
@@ -9920,6 +9936,14 @@ should be able to be added at any place in this file.
<description>Please enter the description of this user action.</description>
</action>
+<action name="MobileRecentlyClosedTabOpen">
+ <owner>finkm@chromium.org</owner>
+ <description>
+ Action indicating the user has opened a recently closed tab from the recent
+ tabs manager.
+ </description>
+</action>
+
<action name="MobileRendererCrashed">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698