Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3786)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java

Issue 2528303003: [NTP] Fixed usage of NewTabPage.ActionAndroid histogram (Closed)
Patch Set: Addressing comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
index aec39b8f0126197ad9cd8df2e047acf0191d4779..b10013e06e609a487d66eb79b319a1900391993e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
@@ -10,6 +10,7 @@ import android.graphics.Bitmap;
import org.chromium.base.ContextUtils;
import org.chromium.base.ThreadUtils;
+import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.browser.UrlConstants;
import org.chromium.chrome.browser.favicon.FaviconHelper;
import org.chromium.chrome.browser.favicon.FaviconHelper.FaviconImageCallback;
@@ -210,7 +211,7 @@ public class RecentTabsManager implements AndroidSyncSettingsObserver, SignInSta
public void openForeignSessionTab(ForeignSession session, ForeignSessionTab tab,
int windowDisposition) {
if (mIsDestroyed) return;
- NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_FOREIGN_SESSION);
+ RecordUserAction.record("MobileForeignSessionOpen");
mForeignSessionHelper.openForeignSessionTab(mTab, session, tab, windowDisposition);
}
@@ -223,7 +224,7 @@ public class RecentTabsManager implements AndroidSyncSettingsObserver, SignInSta
*/
public void openRecentlyClosedTab(RecentlyClosedTab tab, int windowDisposition) {
if (mIsDestroyed) return;
- NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_RECENTLY_CLOSED_ENTRY);
+ RecordUserAction.record("MobileRecentlyClosedTabOpen");
mRecentlyClosedBridge.openRecentlyClosedTab(mTab, tab, windowDisposition);
}

Powered by Google App Engine
This is Rietveld 408576698