chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java - Issue 2528303003: [NTP] Fixed usage of NewTabPage.ActionAndroid histogram

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

Issue 2528303003: [NTP] Fixed usage of NewTabPage.ActionAndroid histogram (Closed)

Patch Set: Addressing comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('j') | tools/metrics/actions/actions.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

index 9ab1e77fc61714e52a45646f83f26b5de46aa9da..7ac51cbd06ff355a73610051386f234a1cd0ac2c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

@@ -21,7 +21,6 @@ import org.chromium.chrome.R;

import org.chromium.chrome.browser.IntentHandler;

import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.document.ChromeLauncherActivity;

-import org.chromium.chrome.browser.ntp.NewTabPageUma;

import org.chromium.chrome.browser.snackbar.Snackbar;

import org.chromium.chrome.browser.snackbar.SnackbarManager;

import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;

@@ -230,7 +229,7 @@ public class BookmarkUtils {

String url = model.getBookmarkById(bookmarkId).getUrl();

- NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_BOOKMARK);

+ RecordUserAction.record("MobileBookmarkOpen");

RecordHistogram.recordEnumeratedHistogram(

"Stars.LaunchLocation", launchLocation, BookmarkLaunchLocation.COUNT);