Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1567)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2528303003: [NTP] Fixed usage of NewTabPage.ActionAndroid histogram (Closed)
Patch Set: Addressing comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index d44997c67f8d8304c3af7cf69f7b097dc4eca3cb..f10df7b0f821993655a4314c6937ba0c5d0049f1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -79,6 +79,7 @@ import org.chromium.chrome.browser.metrics.StartupMetrics;
import org.chromium.chrome.browser.metrics.UmaUtils;
import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
import org.chromium.chrome.browser.ntp.NativePageAssassin;
+import org.chromium.chrome.browser.ntp.NewTabPage;
import org.chromium.chrome.browser.ntp.NewTabPageUma;
import org.chromium.chrome.browser.omaha.OmahaClient;
import org.chromium.chrome.browser.omnibox.AutocompleteController;
@@ -1150,6 +1151,10 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
}
} else if (id == R.id.all_bookmarks_menu_id) {
if (currentTab != null) {
+ if (NewTabPage.isNTPUrl(currentTab.getUrl())) {
+ NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_BOOKMARK);
+ }
+ RecordUserAction.record("MobileMenuAllBookmarks");
getCompositorViewHolder().hideKeyboard(new Runnable() {
@Override
public void run() {
@@ -1157,14 +1162,16 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
BookmarkUtils.showBookmarkManager(ChromeTabbedActivity.this);
}
});
- RecordUserAction.record("MobileMenuAllBookmarks");
}
} else if (id == R.id.recent_tabs_menu_id) {
if (currentTab != null) {
+ if (NewTabPage.isNTPUrl(currentTab.getUrl())) {
+ NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_RECENTLY_CLOSED_ENTRY);
+ }
+ RecordUserAction.record("MobileMenuOpenTabs");
currentTab.loadUrl(new LoadUrlParams(
UrlConstants.RECENT_TABS_URL,
PageTransition.AUTO_BOOKMARK));
- RecordUserAction.record("MobileMenuOpenTabs");
}
} else if (id == R.id.close_all_tabs_menu_id) {
// Close both incognito and normal tabs

Powered by Google App Engine
This is Rietveld 408576698