content/renderer/pepper/pepper_media_stream_track_host_base.cc - Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_media_stream_track_host_base.cc

Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric (Closed)

Patch Set: pointer math tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/pepper_media_stream_track_host_base.cc

diff --git a/content/renderer/pepper/pepper_media_stream_track_host_base.cc b/content/renderer/pepper/pepper_media_stream_track_host_base.cc

index c2b8655fdb4cd97e1704a11e60ce80f1b123f77e..947f8468b3a4bc764089668b8e34b0523e7996b1 100644

--- a/content/renderer/pepper/pepper_media_stream_track_host_base.cc

+++ b/content/renderer/pepper/pepper_media_stream_track_host_base.cc

@@ -47,7 +47,7 @@ bool PepperMediaStreamTrackHostBase::InitBuffers(int32_t number_of_buffers,

// TODO(penghuang): |HostAllocateSharedMemoryBuffer| uses sync IPC. We should

// avoid it.

- base::CheckedNumeric<int32_t> size = number_of_buffers * buffer_size_aligned;

+ base::CheckedNumeric<uint32_t> size = number_of_buffers * buffer_size_aligned;

Tom Sepez 2016/11/30 23:58:27 nice catch.

jschuh 2016/12/01 00:58:55 Thanks. Had to fix about a dozen like this. Better

if (!size.IsValid())

return false;