gpu/command_buffer/client/gles2_implementation.cc - Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/client/gles2_implementation.cc

Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric (Closed)

Patch Set: pointer math tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/client/gles2_implementation.cc

diff --git a/gpu/command_buffer/client/gles2_implementation.cc b/gpu/command_buffer/client/gles2_implementation.cc

index 3424bc2a5310224463bbed535e1e84eed8e336d0..0f12cd4c93d2c81f807d469a9a670f165c6b5f50 100644

--- a/gpu/command_buffer/client/gles2_implementation.cc

+++ b/gpu/command_buffer/client/gles2_implementation.cc

@@ -6327,7 +6327,7 @@ bool GLES2Implementation::PackStringsToBucket(GLsizei count,

const char* func_name) {

DCHECK_LE(0, count);

// Compute the total size.

- base::CheckedNumeric<size_t> total_size = count;

+ base::CheckedNumeric<uint32_t> total_size = count;

total_size += 1;

total_size *= sizeof(GLint);

if (!total_size.IsValid()) {