content/child/font_warmup_win.cc - Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/font_warmup_win.cc

Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric (Closed)

Patch Set: compile cleanup and fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/font_warmup_win.cc

diff --git a/content/child/font_warmup_win.cc b/content/child/font_warmup_win.cc

index 2d3f2323d6cf54d0e64dda6b2105384ae0f9a0b4..739246ba781547d702775424b1152ffb3d02768c 100644

--- a/content/child/font_warmup_win.cc

+++ b/content/child/font_warmup_win.cc

@@ -150,7 +150,8 @@ class FakeGdiObjectFactory {

base::AutoLock scoped_lock(objects_lock_);

curr_handle_++;

// We don't support wrapping the fake handle value.

- void* handle = reinterpret_cast<void*>(curr_handle_.ValueOrDie());

+ void* handle = reinterpret_cast<void*>(

+ static_cast<uintptr_t>(curr_handle_.ValueOrDie()));

scoped_refptr<FakeGdiObject> object(new FakeGdiObject(magic, handle));

objects_[handle] = object;

return object;