content/browser/appcache/appcache_response.cc - Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_response.cc

Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric (Closed)

Patch Set: compile cleanup and fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/appcache/appcache_response.cc

diff --git a/content/browser/appcache/appcache_response.cc b/content/browser/appcache/appcache_response.cc

index dfa205de551f24ef210ecd957e0f9ed2c5c65240..e85ea5fb2a77f91efc8445e1f9bb87d06c54c1d3 100644

--- a/content/browser/appcache/appcache_response.cc

+++ b/content/browser/appcache/appcache_response.cc

@@ -284,7 +284,7 @@ void AppCacheResponseReader::OnIOComplete(int result) {

if (metadata_size > 0) {

reading_metadata_size_ = metadata_size;

info_buffer_->http_info->metadata = new net::IOBufferWithSize(

- base::CheckedNumeric<size_t>(metadata_size).ValueOrDie());

+ base::checked_cast<size_t>(metadata_size));

ReadRaw(kResponseMetadataIndex, 0,

info_buffer_->http_info->metadata.get(), metadata_size);

return;