[LayoutNG] Correct inline size for children of multicol containers.

[LayoutNG] Correct inline size for children of multicol containers.

This will lay out multicol containers in one single tall column, without any
support for fragmentation or column balancing.

Also had to disable creation of the anonymous LayoutMultiColumnFlowThread child
of multicol containers, since that's not going to be used in LayoutNG.

The algorithm for calculating the used values of column-width and column-count
can be found here: https://drafts.csswg.org/css-multicol-1/#pseudo-algorithm

Committed: https://crrev.com/620f2fc2f3543cff1678c4137fc86c198d55e9e3
Cr-Commit-Position: refs/heads/master@{#434971}

[mstensho (USE GERRIT), 2016-11-25 21:02:09]

mstensho@opera.com changed reviewers:
+ eae@chromium.org

[ikilpatrick, 2016-11-28 17:12:45]

ikilpatrick@chromium.org changed reviewers:
+ cbiesinger@chromium.org, ikilpatrick@chromium.org

[ikilpatrick, 2016-11-28 17:12:46]

lgtm

https://codereview.chromium.org/2528203002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc (right):

https://codereview.chromium.org/2528203002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:231: int
ResolveUsedColumnCount(int computed_count,
would it be better to split multicol utils out into another file?
(ng_multilcol_utils.cc)

up to you.

(slight preference if we'll adding more).

https://codereview.chromium.org/2528203002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_length_utils.h (right):

https://codereview.chromium.org/2528203002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_length_utils.h:83: CORE_EXPORT
LayoutUnit ResolveUsedColumnInlineSize(LayoutUnit available_size,
.nit newline above this.

[mstensho (USE GERRIT), 2016-11-28 19:30:29]

https://codereview.chromium.org/2528203002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc (right):

https://codereview.chromium.org/2528203002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:231: int
ResolveUsedColumnCount(int computed_count,
On 2016/11/28 17:12:46, ikilpatrick wrote:
> would it be better to split multicol utils out into another file?
> (ng_multilcol_utils.cc)
> 
> up to you.
> 
> (slight preference if we'll adding more).

Not planning on adding more. I think I'll keep it here for now, if that's fine.

https://codereview.chromium.org/2528203002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_length_utils.h (right):

https://codereview.chromium.org/2528203002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_length_utils.h:83: CORE_EXPORT
LayoutUnit ResolveUsedColumnInlineSize(LayoutUnit available_size,
On 2016/11/28 17:12:46, ikilpatrick wrote:
> .nit newline above this.

Even if it's just an overload? The comment above applies to both functions.

[mstensho (USE GERRIT), 2016-11-29 11:44:41]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-11-29 11:44:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 13:20:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480419881863030, "parent_rev":
"de7119ed112290cffb1624b3edd81552e128e13d", "commit_rev":
"2329e228a0591feb8a2dacc6dd1303daee94ffa5"}

[commit-bot: I haz the power, 2016-11-29 13:21:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-29 13:23:55]

Description was changed from

==========
[LayoutNG] Correct inline size for children of multicol containers.

This will lay out multicol containers in one single tall column, without any
support for fragmentation or column balancing.

Also had to disable creation of the anonymous LayoutMultiColumnFlowThread child
of multicol containers, since that's not going to be used in LayoutNG.

The algorithm for calculating the used values of column-width and column-count
can be found here: https://drafts.csswg.org/css-multicol-1/#pseudo-algorithm
==========

to

==========
[LayoutNG] Correct inline size for children of multicol containers.

This will lay out multicol containers in one single tall column, without any
support for fragmentation or column balancing.

Also had to disable creation of the anonymous LayoutMultiColumnFlowThread child
of multicol containers, since that's not going to be used in LayoutNG.

The algorithm for calculating the used values of column-width and column-count
can be found here: https://drafts.csswg.org/css-multicol-1/#pseudo-algorithm

Committed: https://crrev.com/620f2fc2f3543cff1678c4137fc86c198d55e9e3
Cr-Commit-Position: refs/heads/master@{#434971}
==========

[commit-bot: I haz the power, 2016-11-29 13:23:56]

Patchset 1 (id:??) landed as
https://crrev.com/620f2fc2f3543cff1678c4137fc86c198d55e9e3
Cr-Commit-Position: refs/heads/master@{#434971}