Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_length_utils.h

Issue 2528203002: [LayoutNG] Correct inline size for children of multicol containers. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_length_utils.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h b/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h
index 9931eb2314d2e224017a8363e1573855b95075b3..5414305345fbac01a94cace30954db79a0d5e9e1 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h
@@ -67,6 +67,24 @@ CORE_EXPORT LayoutUnit ComputeBlockSizeForFragment(const NGConstraintSpace&,
const ComputedStyle&,
LayoutUnit contentSize);
+// Based on available inline size, CSS computed column-width, CSS computed
+// column-count and CSS used column-gap, return CSS used column-count.
+CORE_EXPORT int ResolveUsedColumnCount(int computed_count,
+ LayoutUnit computed_size,
+ LayoutUnit used_gap,
+ LayoutUnit available_size);
+
+// Based on available inline size, CSS computed column-width, CSS computed
+// column-count and CSS used column-gap, return CSS used column-width.
+CORE_EXPORT LayoutUnit ResolveUsedColumnInlineSize(int computed_count,
+ LayoutUnit computed_size,
+ LayoutUnit used_gap,
+ LayoutUnit available_size);
+CORE_EXPORT LayoutUnit ResolveUsedColumnInlineSize(LayoutUnit available_size,
ikilpatrick 2016/11/28 17:12:46 .nit newline above this.
mstensho (USE GERRIT) 2016/11/28 19:30:29 Even if it's just an overload? The comment above a
+ const ComputedStyle&);
+
+CORE_EXPORT LayoutUnit ResolveUsedColumnGap(const ComputedStyle&);
+
CORE_EXPORT NGBoxStrut ComputeMargins(const NGConstraintSpace&,
const ComputedStyle&,
const NGWritingMode writing_mode,

Powered by Google App Engine
This is Rietveld 408576698